From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nam Cao <namcaov@gmail.com>
Cc: UMWARI JOVIAL <umwarijovial@gmail.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH] Fixed[ERROR:trailing whitespace and braces around scalar initializer]
Date: Thu, 27 Oct 2022 10:56:10 +0300 [thread overview]
Message-ID: <Y1o5mktrnE5rbtCO@kadam> (raw)
In-Reply-To: <20221026171430.GA5592@nam-dell>
On Wed, Oct 26, 2022 at 07:14:34PM +0200, Nam Cao wrote:
> On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote:
> > Using the checkpatch.pl script, found the below errors and fixed
> > ERROR: trailing whitespace
> > CHECK: Please don't use multiple blank lines
> > warning: braces around scalar initializer
> >
> > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
> > ---
> > drivers/staging/most/dim2/dim2.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> > index 7a5f80e637a0..28259ce05024 100644
> > --- a/drivers/staging/most/dim2/dim2.c
> > +++ b/drivers/staging/most/dim2/dim2.c
> > @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev)
> > writel(0x04, dev->io_base + 0x600);
> > }
> >
> > -
> > /* BBCR = 0b11 */
> > writel(0x03, dev->io_base + 0x500);
> > writel(0x0002FF02, dev->io_base + 0x508);
> > @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = {
> > {
> > .compatible = "xlnx,axi4-os62420_6pin-1.00.a",
> > },
> > - {},
>
> I'm no expert, but this looks like a null terminator and probably
> should not be removed.
You're absolutely correct. Also I tried to see why checkpatch.pl was
printing an error for this but it doesn't print an error for me.
regards,
dan carpenter
next prev parent reply other threads:[~2022-10-27 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 13:28 [PATCH] Fixed[ERROR:trailing whitespace and braces around scalar initializer] UMWARI JOVIAL
2022-10-26 13:53 ` Greg KH
2022-10-26 17:14 ` Nam Cao
2022-10-27 7:56 ` Dan Carpenter [this message]
2022-10-28 4:56 ` jovial umwari
2022-10-27 19:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1o5mktrnE5rbtCO@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=namcaov@gmail.com \
--cc=outreachy@lists.linux.dev \
--cc=umwarijovial@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox