From: Greg KH <gregkh@linuxfoundation.org>
To: Tanju Brunostar <tanjubrunostar0@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Subject: Re: [PATCH v5 2/6] staging: vt6655: refactor code in s_uGetRTSCTSDuration
Date: Thu, 27 Oct 2022 16:50:26 +0200 [thread overview]
Message-ID: <Y1qaskO7AN7nqc9R@kroah.com> (raw)
In-Reply-To: <CAHJEyKVpK=BSkuM_RmJ+eUYApYJig8wfqDP4nM=cou_0mThHuw@mail.gmail.com>
On Thu, Oct 27, 2022 at 02:09:52PM +0100, Tanju Brunostar wrote:
> On Thu, Oct 27, 2022 at 10:19 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Oct 27, 2022 at 08:59:04AM +0000, Tanjuate Brunostar wrote:
> > > refactor long lines of code in the function: s_uGetRTSCTSDuration
> >
> > Please write full sentences.
> >
> > Also please read the in-kernel documentation for how to write good
> > changelog text. Specifically look at the section entitled "The
> > canonical patch format" in the kernel file,
> > Documentation/SubmittingPatches for a description of how to do this
> > properly.
> >
> > Do this for all of the patches in this series.
> >
> > thanks,
> >
> > greg k-h
>
> Hello Greg
> the file does not exist in Documentations
$ cat Documentation/SubmittingPatches
This file has moved to process/submitting-patches.rst
> Also, I had to make the sentences shorter because you said changelog
> text was too long.
You had too long of a single line. Wrap your lines.
Look at all of the changelogs for the driver itself as examples.
thanks,
greg k-h
next prev parent reply other threads:[~2022-10-27 14:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 6:01 [PATCH v5 0/6] staging: vt6655: a series of checkpatch fixes on the file: rxtx.c Tanjuate Brunostar
2022-10-27 6:01 ` [PATCH v5 1/6] staging: vt6655: fix lines ending in a '(' Tanjuate Brunostar
2022-10-27 8:59 ` Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 " Tanjuate Brunostar
2022-10-27 9:20 ` [PATCH v5 " Greg KH
2022-10-28 5:55 ` [PATCH v6 " Philipp Hortmann
2022-10-28 6:39 ` [PATCH v7 1/6] staging: vt6655: fix lines of code " Tanjuate Brunostar
2022-10-28 14:57 ` Philipp Hortmann
2022-10-28 16:42 ` Tanju Brunostar
2022-10-28 17:52 ` Alison Schofield
2022-10-28 17:59 ` Tanju Brunostar
2022-10-27 6:01 ` [PATCH v5 2/6] staging: vt6655: refactor code in s_uGetRTSCTSDuration Tanjuate Brunostar
2022-10-27 6:37 ` Greg KH
2022-10-27 8:59 ` Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 " Tanjuate Brunostar
2022-10-27 9:19 ` [PATCH v5 " Greg KH
2022-10-27 13:09 ` Tanju Brunostar
2022-10-27 14:50 ` Greg KH [this message]
2022-10-28 6:39 ` [PATCH v7 2/6] staging: vt6655: split code lines " Tanjuate Brunostar
2022-10-27 6:01 ` [PATCH v5 3/6] staging: vt6655: refactor code in s_uFillDataHead Tanjuate Brunostar
2022-10-27 8:59 ` Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 " Tanjuate Brunostar
2022-10-28 6:39 ` [PATCH v7 3/6] staging: vt6655: split long lines of " Tanjuate Brunostar
2022-10-27 6:01 ` [PATCH v5 4/6] staging: vt6655: refactor code in s_vGenerateTxParameter Tanjuate Brunostar
2022-10-27 8:59 ` Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 " Tanjuate Brunostar
2022-10-28 6:39 ` [PATCH v7 4/6] staging: vt6655: split long lines of " Tanjuate Brunostar
2022-10-27 6:01 ` [PATCH v5 5/6] staging: vt6655: refactor code in the rest of the file Tanjuate Brunostar
2022-10-27 8:59 ` Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 " Tanjuate Brunostar
2022-10-28 6:39 ` [PATCH v7 5/6] staging: vt6655: split long lines of code in " Tanjuate Brunostar
2022-10-27 6:01 ` [PATCH v5 6/6] staging: vt6655: refactor code to avoid a line ending in '(' Tanjuate Brunostar
2022-10-27 8:59 ` Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 " Tanjuate Brunostar
2022-10-28 6:39 ` [PATCH v7 6/6] staging: vt6655: fix lines of code ending in a '(' Tanjuate Brunostar
2022-10-28 17:40 ` Tanjuate Brunostar
2022-10-27 8:59 ` [PATCH v5 0/6] staging: vt6655: a series of checkpatch fixes on the file: rxtx.c Tanjuate Brunostar
2022-10-27 9:05 ` Tanjuate Brunostar
2022-10-28 6:34 ` Tanjuate Brunostar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1qaskO7AN7nqc9R@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=tanjubrunostar0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).