From: Greg KH <gregkh@linuxfoundation.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-staging@lists.linux.dev, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH] staging: media: atomisp: make hive_int8 explictly signed
Date: Thu, 3 Nov 2022 01:40:54 +0100 [thread overview]
Message-ID: <Y2MOFrprCkZVAiCr@kroah.com> (raw)
In-Reply-To: <20221103001914.81849-1-Jason@zx2c4.com>
On Thu, Nov 03, 2022 at 01:19:14AM +0100, Jason A. Donenfeld wrote:
> The current definition of hive_int8 is a naked char, without any sign
> specifier. This is incorrect on platforms such as arm, where char is
> unsigned. Fortunately nothing in the kernel actually uses a hive_int8
> type, but in case it gets used later rather than removed, this makes it
> explicitly signed.
>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> Greg - if you're going to take this for 6.1, that's fine with me.
> Otherwise, if it's for 6.2, I'll take this in my unsigned-char tree to
> keep all of these fixups together. -Jason
I don't take drivers/staging/media/* patches, they go through Mauro's
tree, so I'll let him and you fight it out here :)
thanks,
greg k-h
prev parent reply other threads:[~2022-11-03 0:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 0:19 [PATCH] staging: media: atomisp: make hive_int8 explictly signed Jason A. Donenfeld
2022-11-03 0:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2MOFrprCkZVAiCr@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).