From: Deepak R Varma <drv@mailo.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Pavel Skripkin <paskripkin@gmail.com>,
outreachy@lists.linux.dev,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Use flexible-array for one length array member
Date: Thu, 3 Nov 2022 10:55:47 +0530 [thread overview]
Message-ID: <Y2NQ23peeelHrCqW@qemulion> (raw)
In-Reply-To: <Y2NQBgUdNPB7g0Tf@kadam>
On Thu, Nov 03, 2022 at 08:22:14AM +0300, Dan Carpenter wrote:
> On Thu, Nov 03, 2022 at 12:49:38AM +0530, Deepak R Varma wrote:
> > I am wondering if ijk_matrix_regs_set (or IQKMatrixRegSetting) is a one element
> > array, why is it declared as a two dimensional array? Can this be a simple one
> > dimensional array instead? Is this the cleanup you are referring to when you say
> > "code is messy and should be cleaned up"?
>
> Yes. You have interpreted that correctly.
Thank you for the confirmation. This will be an interesting correction. I will
review and submit a patch shortly.
Thank you,
./drv
>
> regards,
> dan carpenter
>
>
prev parent reply other threads:[~2022-11-03 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 12:56 [PATCH] staging: r8188eu: Use flexible-array for one length array member Deepak R Varma
2022-10-28 14:03 ` Pavel Skripkin
2022-10-28 14:11 ` Deepak R Varma
2022-10-28 14:43 ` Dan Carpenter
2022-11-02 19:19 ` Deepak R Varma
2022-11-03 5:22 ` Dan Carpenter
2022-11-03 5:25 ` Deepak R Varma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2NQ23peeelHrCqW@qemulion \
--to=drv@mailo.com \
--cc=Larry.Finger@lwfinger.net \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox