From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E36507E2;
	Thu,  3 Nov 2022 05:22:18 +0000 (UTC)
Received: by mail-wr1-f50.google.com with SMTP id z14so1031051wrn.7;
        Wed, 02 Nov 2022 22:22:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=YHeYRtbQ3BOR9DbNBl//b/ECiZLyzDKiq1z7LfU80Ro=;
        b=cLRHFFC/4i0kC25woN7rBisVFZbJAi5O+WO3FpKztDcZ6Sih+MKjwVgaMCk7b1ZlmK
         6AwoRT0fsSAqWkmu1bypc3oogAZ3Fcc0WkUSA0hslBJ34GxfhcIVScg64Qa5m0aw8YqR
         I09X2XBzK+uMJCx9zJuN1uy+FtlIyQebL3/UDviODhjjTpR2vOqFnXWOghkYllr17/QL
         x537E4VG3qPA0aR6uwh20FQIsTewE5tgZSoVqKIwfzQwvtSUkKB4pcfFPs36m6vSr20v
         jtXxlKqxd269Wc1hV+2zqd4zj8DrttsBMAi5xoXwGbgubL7uaXrQ402EpBYPHwDQPwRF
         ReTQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=YHeYRtbQ3BOR9DbNBl//b/ECiZLyzDKiq1z7LfU80Ro=;
        b=Hrs0u+iT0U/8pYSXz8fd+Bdw8xs2cmqABcn2ZUCwEB4O/+tiM9LAHcpp3EIzYXQAoE
         Tr1UOvPKvPaD59aPdlAwGRLGUYByEX0F0OVb/31qLhPp7THPGZT0iIo4TG/mv/ifyNfl
         VPCZsz5wHb50cSFL4d62VRzPDAf4+SxQw6hL0c6xlaYG/bfGDBUDMHZYsonuYDPQ+sto
         yP4d4IDJWFi0ZBpJ5uMgjamLxee5FDR4nk3Kc/1qG9WzVovLY6eIPCFT57UVVqKEeE8m
         YZFt/WPFx1ZlriMXjzvfaeHB+YJw8ozZV2OB/LCrvf2fLmFmvJtEafiWMSLKO0ugYviV
         iG1A==
X-Gm-Message-State: ACrzQf2pVYxF3Vn1Uw5mJTWCEi8ga1894OVImkiFIzuS9sm0ohUNjQNa
	eUFpS5+NrZTqlWIh+xUKYn0=
X-Google-Smtp-Source: AMsMyM7pvkJpMNweAPAMF6FegnUvSD//sJCqTd+gnDmriuq/ro/yXz1HEH0nR09Za+uaQvmBFQOsdQ==
X-Received: by 2002:a5d:4410:0:b0:236:a8f9:268f with SMTP id z16-20020a5d4410000000b00236a8f9268fmr17515507wrq.405.1667452937156;
        Wed, 02 Nov 2022 22:22:17 -0700 (PDT)
Received: from localhost ([102.36.222.112])
        by smtp.gmail.com with ESMTPSA id n124-20020a1ca482000000b003b4a68645e9sm4019487wme.34.2022.11.02.22.22.16
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 02 Nov 2022 22:22:16 -0700 (PDT)
Date: Thu, 3 Nov 2022 08:22:14 +0300
From: Dan Carpenter <error27@gmail.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Pavel Skripkin <paskripkin@gmail.com>, outreachy@lists.linux.dev,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Use flexible-array for one length
 array member
Message-ID: <Y2NQBgUdNPB7g0Tf@kadam>
References: <Y1vRivFfRD6VoBt/@ubunlion>
 <642519a2-664d-d837-983a-1d5bbc72a25e@gmail.com>
 <Y1vjKtM9druO2bSN@ubunlion>
 <Y1vqd/ij5WqcL3Qe@kadam>
 <Y2LCykj5Ntx7yHxu@qemulion>
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y2LCykj5Ntx7yHxu@qemulion>

On Thu, Nov 03, 2022 at 12:49:38AM +0530, Deepak R Varma wrote:
> I am wondering if ijk_matrix_regs_set (or IQKMatrixRegSetting) is a one element
> array, why is it declared as a two dimensional array? Can this be a simple one
> dimensional array instead? Is this the cleanup you are referring to when you say
> "code is messy and should be cleaned up"?

Yes.  You have interpreted that correctly.

regards,
dan carpenter