From: Dan Carpenter <error27@gmail.com>
To: Tanju Brunostar <tanjubrunostar0@gmail.com>
Cc: Joe Perches <joe@perches.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH V4 1/2] staging: vt6655: change the function name s_vFillRTSHead
Date: Thu, 3 Nov 2022 12:07:19 +0300 [thread overview]
Message-ID: <Y2OExzH0QJqHEfNf@kadam> (raw)
In-Reply-To: <CAHJEyKV75q90E1OU2YOGK70EBLm8dQe181m_nS_qmPRsPaB8TQ@mail.gmail.com>
On Thu, Nov 03, 2022 at 09:48:59AM +0100, Tanju Brunostar wrote:
> The second commit under this patchset resolves this. please take a
> look at it and let me know if I should change anything
>
Please don't top post on email.
http://www.catb.org/jargon/html/T/top-post.html
Don't break the kernel and then fix it in a later patch. Just fix it
without first breaking it.
regards,
dan carpenter
next prev parent reply other threads:[~2022-11-03 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 14:08 [PATCH V4 0/2] staging: vt6655: some checkpatch fixes in the file rxtx.c Tanjuate Brunostar
2022-11-02 14:08 ` [PATCH V4 1/2] staging: vt6655: change the function name s_vFillRTSHead Tanjuate Brunostar
2022-11-02 16:42 ` Joe Perches
2022-11-03 8:48 ` Tanju Brunostar
2022-11-03 9:07 ` Dan Carpenter [this message]
2022-11-03 9:17 ` Tanju Brunostar
2022-11-02 14:08 ` [PATCH V4 2/2] staging: vt6655: Join some lines of code to avoid code lines ending in ( Tanjuate Brunostar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2OExzH0QJqHEfNf@kadam \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=tanjubrunostar0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).