From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18BE26FAE; Thu, 3 Nov 2022 11:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667476568; bh=/NLwbR49Avnf18FfogKpbZ5T40/76ghuIMELqgmgUkY=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:MIME-Version: Content-Type; b=X+HOMa6Cqoa27KMD5oT1MjY3Gz7vKXD/EPT7mnn+e2u8/jdt+Wa/5NI46KgaFlst5 fTU2aE87wU4JlJvUxqPZXEVz6g0qAviYe19VUTb4WTAAYMyS9QqVGyJ50modG1ya16 p3NWP+ln9ofRwUjnWtprBu3dajdSkNnXfY9Wu09k= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Thu, 3 Nov 2022 12:56:08 +0100 (CET) X-EA-Auth: fZNaHUg4jtpGZewYR6tJSl4CE3GuUAnFJlzHa26bu/s68tjys15zyF84sNeCegVJFSM5djMwkw2RoegSYSsa5vTs/Mtwkcxh Date: Thu, 3 Nov 2022 17:26:01 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Larry Finger , Phillip Potter , Pavel Skripkin , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: r8188eu: replace one element 2D array by 1D array Message-ID: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline A single element two dimensional array is constrained to index 0 for that element. This constraint makes it similar to a one dimensional array. Hence convert such array to a simplified one dimensional equivalent. Resultant code is simpler and easy to maintain. Suggested-by: Dan Carpenter Signed-off-by: Deepak R Varma --- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +- drivers/staging/r8188eu/include/odm.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c index 622f95d3f2ed..c0706c5b3fd8 100644 --- a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c +++ b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c @@ -886,7 +886,7 @@ void PHY_IQCalibrate_8188E(struct adapter *adapt, bool recovery) /* by sherry 20120321 */ if (final_candidate < 4) { for (i = 0; i < IQK_Matrix_REG_NUM; i++) - dm_odm->RFCalibrateInfo.IQKMatrixRegSetting.Value[0][i] = result[final_candidate][i]; + dm_odm->RFCalibrateInfo.IQKMatrixRegSetting.Value[i] = result[final_candidate][i]; dm_odm->RFCalibrateInfo.IQKMatrixRegSetting.bIQKDone = true; } diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h index 89b01dd614ba..0008615ba858 100644 --- a/drivers/staging/r8188eu/include/odm.h +++ b/drivers/staging/r8188eu/include/odm.h @@ -166,7 +166,7 @@ struct odm_ra_info { struct ijk_matrix_regs_set { bool bIQKDone; - s32 Value[1][IQK_Matrix_REG_NUM]; + s32 Value[IQK_Matrix_REG_NUM]; }; struct odm_rf_cal { -- 2.34.1