From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2069D8471;
	Fri,  4 Nov 2022 16:55:15 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo;
	t=1667580912; bh=hK6mqgJ+sOVpRgVX06v+zmV4Tw1LFEgTKYWKc1OCxOU=;
	h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References:
	 MIME-Version:Content-Type:In-Reply-To;
	b=KMvnN5sopXVCGeEFEYViuop2afWaMmcxcYKF3G8fuUNrIhtTayo0N/FTszpEii0iD
	 lwsUr/CswOSCtaRWP+O6nKx+s8xTj2bAXJFtu88rekt/qX6+qR0OSG0Mrtsh5I6XlX
	 YAFNMdRPLUP0TRmWXKTw/DjFVcL2CL11JUfquGxQ=
Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP
	via ip-206.mailobj.net [213.182.55.206]
	Fri,  4 Nov 2022 17:55:12 +0100 (CET)
X-EA-Auth: /omeScJ7L58w8McXgv460L47f3glzT4opVlNXbZp8Yq58W9dGImxfJjOe3K13s7qAoWmdE4gpkgpUfxlP/b/bTrajVVo0I5h
Date: Fri, 4 Nov 2022 22:25:06 +0530
From: Deepak R Varma <drv@mailo.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: outreachy@lists.linux.dev, Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Pavel Skripkin <paskripkin@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unused struct declarations
Message-ID: <Y2VD6qTxXPpuufOo@qemulion>
References: <Y2LYvhr74ng+xFbz@qemulion>
 <e76c5fd4-442b-0f0e-73e8-c17acf11b471@gmail.com>
 <Y2OOM8g0Qj1o6dRI@qemulion>
 <2aeb10bc-178f-836e-eecd-c77f3eb2f0b5@gmail.com>
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2aeb10bc-178f-836e-eecd-c77f3eb2f0b5@gmail.com>

On Thu, Nov 03, 2022 at 10:19:05PM +0100, Philipp Hortmann wrote:
> On 11/3/22 10:47, Deepak R Varma wrote:
> > Hello Philipp,
> > Thank you for testing the changes.
> >
> > Request (not urgent):
> > Can you please help me understand how do you
> > test such changes? Do we need specific hardware for functional tests? Is there a
> > documentation available to know more about the testing? I am interested in
> > attaching a physical device to my machine and be able to debug and test the
> > changes. Can you please provide details when you have time?
> >
> > Thank you in advance!
> > ./drv
>
> Hi Deepak,
>
> I do have one device for the following drivers:
>
> vt6656
> vt6655
> r8188eu
> r8192e_pci
> r8712u

Wow... that sounds like a very useful set (and a lot of testing time :) )

>
> Minimum test is to measure the transfer speed and see if that is as
> expected.
>
> When I doubt that the changed code is used I use ftrace to see if the code
> is used. But of course I do not test every possibility.

Okay. May be as I gain more knowledge, I will be able to apply it as well. I
hope it will be okay to connect with you in future if an opportunity arises.

>
> I hope you have the money to be able to buy hardware. Without it is not fun.
>
> I would choose r8188eu (USB) or r8192e_pci.

Thank you so much for the recommendation. I will find out the cost and see if I
can buy one of those.

Have a great weekend!
./drv

>
> Bye Philipp
>