From: Jacob Bai <jacob.bai.au@gmail.com>
To: Joe Perches <joe@perches.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] staging: rtl8192e: remove unnecesscary macro defines
Date: Sun, 6 Nov 2022 12:31:15 +1100 [thread overview]
Message-ID: <Y2cOY/qq8hFrxV+m@jacob-Ubuntu> (raw)
In-Reply-To: <8fea8008f0ebb85d7e893513117347712e68fba5.camel@perches.com>
On Sat, Nov 05, 2022 at 06:18:41PM -0700, Joe Perches wrote:
> On Sun, 2022-11-06 at 12:11 +1100, Jacob Bai wrote:
> > remove useless macro defines
> []
> > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> > index eabb4187d907..aad1842857c0 100644
> > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> > @@ -307,12 +307,12 @@ void rtl92e_config_mac(struct net_device *dev)
> > struct r8192_priv *priv = rtllib_priv(dev);
> >
> > if (priv->bTXPowerDataReadFromEEPORM) {
> > - dwArrayLen = MACPHY_Array_PGLength;
> > - pdwArray = Rtl819XMACPHY_Array_PG;
> > + dwArrayLen = RTL8192E_MAC_ARRAY_PG_LEN;
> > + pdwArray = RTL8192E_MAC_ARRAY_PG;
>
> Perhaps use ARRAY_SIZE instead.
>
As the other drivers under rtlwifi are using ARRAY_LEN or ARRAY_LENGTH,
maybe it's better to keep the same format?
next prev parent reply other threads:[~2022-11-06 1:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 1:11 [PATCH v2 0/3] staging: rtl8192e: trivial code cleanup patches Jacob Bai
2022-11-06 1:11 ` [PATCH v2 1/3] staging: rtl8192e: rename tables in r8192e_hwimg.c Jacob Bai
2022-11-06 1:11 ` [PATCH v2 2/3] staging: rtl8192e: rename r8192E_hwimg.c/h to table.c/h Jacob Bai
2022-11-06 1:11 ` [PATCH v2 3/3] staging: rtl8192e: remove unnecesscary macro defines Jacob Bai
2022-11-06 1:18 ` Joe Perches
2022-11-06 1:31 ` Jacob Bai [this message]
2022-11-06 1:45 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2cOY/qq8hFrxV+m@jacob-Ubuntu \
--to=jacob.bai.au@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).