From: Deepak R Varma <drv@mailo.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8723bs: Simplify underutilized 2D array to 1D array
Date: Tue, 8 Nov 2022 23:19:56 +0530 [thread overview]
Message-ID: <Y2qWxOqEZNWekzUJ@qemulion> (raw)
In-Reply-To: <Y2pzjVVtBe04Zyna@kroah.com>
On Tue, Nov 08, 2022 at 04:19:41PM +0100, Greg Kroah-Hartman wrote:
> On Sat, Nov 05, 2022 at 02:47:49PM +0530, Deepak R Varma wrote:
> > On Sat, Nov 05, 2022 at 02:14:12PM +0530, Deepak R Varma wrote:
> > Hello Greg,
> > Upon further review of the structure, I observed that the member "bIQKDone" is
> > also not used anywhere in the code and it can be removed as well. That cleanup
> > will lead to replacing this entire structure by a simple one dimensional 'Value"
> > array.
> >
> > Please suggest if I should make that change and send in a revision?
>
> Yes, that would be a better overall change.
Hello Greg,
The patch is resubmitted earlier with following subject:
[PATCH v2] staging: rtl8723bs: replace underutilized struct by array variable
Thank you,
./drv
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2022-11-08 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 18:34 [PATCH 0/2] staging: rtl8723bs: struct iqk_matrix_regs_setting cleanup Deepak R Varma
2022-11-04 18:34 ` [PATCH 1/2] staging: rtl8723bs: Simplify underutilized 2D array to 1D array Deepak R Varma
2022-11-05 8:36 ` Greg Kroah-Hartman
2022-11-05 8:44 ` Deepak R Varma
2022-11-05 9:17 ` Deepak R Varma
2022-11-08 15:19 ` Greg Kroah-Hartman
2022-11-08 17:49 ` Deepak R Varma [this message]
2022-11-04 18:35 ` [PATCH 2/2] staging: rtl8723bs: Remove unused member variable Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2qWxOqEZNWekzUJ@qemulion \
--to=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox