[PATCH v2] staging: fieldbus: replace snprintf in show functions with sysfs_emit

Deepak R Varma
2022-11-09T05:56:59Z

The show() methods should only use sysfs_emit() when formatting values
to be returned to the user space.
Ref: Documentation/filesystems/sysfs.rst
Issue identified by coccicheck.

Signed-off-by: Deepak R Varma <drv@mailo.com>
---

Changes in v2:
1. Switch to using sysfs_emit instead of scnprintf
2. Update patch subject and log accordingly
Feedback from gregkh@linuxfoundation.org

drivers/staging/fieldbus/dev_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/fieldbus/dev_core.c b/drivers/staging/fieldbus/dev_core.c
index 5aab734606ea..d32599f4eb44 100644
--- a/drivers/staging/fieldbus/dev_core.c
+++ b/drivers/staging/fieldbus/dev_core.c
@@ -67,10 +67,10 @@ static ssize_t card_name_show(struct device *dev, struct device_attribute *attr,
struct fieldbus_dev *fb = dev_get_drvdata(dev);

/*
- * card_name was provided by child driver, could potentially be long.
- * protect against buffer overrun.
+ * sysfs provides PAGE_SIZE long buffer to take care of potentially
+ * long card_name provided by child driver.
*/
- return snprintf(buf, PAGE_SIZE, "%s\n", fb->card_name);
+ return sysfs_emit(buf, "%s\n", fb->card_name);
}
static DEVICE_ATTR_RO(card_name);

--
2.34.1