From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E5082FAF for ; Thu, 17 Nov 2022 13:50:31 +0000 (UTC) Received: by mail-wm1-f44.google.com with SMTP id r126-20020a1c4484000000b003cffd336e24so459407wma.4 for ; Thu, 17 Nov 2022 05:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bkweVlMZ0g0+u7fAZmYu/Pqe+/vJOvCRgkDADGgIA2s=; b=iJErqAPL10YQES5nboDu00n0QHsr9m4pN7t6xt4KI04Mz+DP7wuasgAh2j2ltzCP7P fbniCxcdL0NkfwMQoE99Pj9zmUXLDPDT3R6K6p13KyhzVYaKQwJpMWrpG3yn0nxVIsPO hICRLxHlr/hxX/h9x9nxYuVzsZI+aUqWWOhIem0U/TeB8i7xrljLnMRdnsxMVn+rAC+6 i2QyMpIte+Tdfes76l9WVet1zrSFBmN+ibKexVtjOdfBhthB5FtSSHDD2t4+OFCMJNr7 27HUbFg9xFyyN7mlaz0e39o+8rNa/0vDhU9BgUsDllr+H49glFZ+Jx4zyZWdz7d2e/gB zaoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bkweVlMZ0g0+u7fAZmYu/Pqe+/vJOvCRgkDADGgIA2s=; b=yAJiYJ9KtUu80FtIKO69//6Pto4u6KWb7+BXGMFLTgh+SM8TyWGP1AGC1tOfh2AO0V N84sHD769couzXpFVJzYhIgqnq5NY7rhQrJpz19JpR639xS8ztqrMzaN4ziSYlRK7WvK ly6Iglpv9gHthkrcBjyFc9C6BcMevAsBuT8/6xdOCTXGwIh8YmkAfPJ2HDEiGQnVgIlk XVjDuYn4mjnpCqOOKlQCIOYKyEkkhUYTRpN1D3wRLvkGi/F3YvTDhFkDDLtSIBS4FvwP Z9DZwSfTxHbF6teBrANahx6M/mYp7OQkRjTYgAbAQpRYeQ0ISn/BfxXOlmbml/apvSI+ hxjQ== X-Gm-Message-State: ANoB5plBzbS7UMTWw04qYjirg1CoVdY5ss1vnQ03ufFAnUQGQ00e3MQD wWsTtKcYI45i9XubOU+iXXE= X-Google-Smtp-Source: AA0mqf7iBPPgpyhI2Y14QqG2ZA1qB6Du3tc53khekXZEK+mYE7Ut5oqgY1wpI9Q2tux1n5o87QHlkA== X-Received: by 2002:a05:600c:188a:b0:3cf:8e62:f769 with SMTP id x10-20020a05600c188a00b003cf8e62f769mr5426381wmp.52.1668693029460; Thu, 17 Nov 2022 05:50:29 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id p11-20020a05600c468b00b003c65c9a36dfsm1369329wmo.48.2022.11.17.05.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 05:50:29 -0800 (PST) Date: Thu, 17 Nov 2022 16:50:24 +0300 From: Dan Carpenter To: Umang Jain Cc: Greg Kroah-Hartman , Florian Fainelli , Broadcom internal kernel review list , Stefan Wahren , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH 1/2] staging: vc04_services: mmal-vchiq: Do not assign bool to u32 Message-ID: References: <20221117125953.88441-1-umang.jain@ideasonboard.com> <20221117125953.88441-2-umang.jain@ideasonboard.com> <5f139eeb-24cc-85c1-34b6-f1334313839f@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f139eeb-24cc-85c1-34b6-f1334313839f@ideasonboard.com> On Thu, Nov 17, 2022 at 06:57:07PM +0530, Umang Jain wrote: > Hi Greg, > > Thanks for the comment, > > On 11/17/22 6:43 PM, Greg Kroah-Hartman wrote: > > On Thu, Nov 17, 2022 at 06:29:52PM +0530, Umang Jain wrote: > > > From: Dave Stevenson > > > > > > struct vchiq_mmal_component.enabled is a u32 type. Do not assign > > > it a bool. > > > > > > Fixes: 640e77466e69 ("staging: mmal-vchiq: Avoid use of bool in structures") > > > Signed-off-by: Dave Stevenson > > > Signed-off-by: Umang Jain > > > --- > > > drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > > > index cb921c94996a..17f8ceda87ca 100644 > > > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > > > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > > > @@ -1773,7 +1773,7 @@ int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance, > > > ret = enable_component(instance, component); > > > if (ret == 0) > > > - component->enabled = true; > > > + component->enabled = 1; > > Why not make enabled a bool instead? > > Makes sense. It would probably require reverting the 640e77466e69 ("staging: > mmal-vchiq: Avoid use of bool in structures") > Reverting that patch seems like a good idea. regards, dan carpenter