From: Dan Carpenter <error27@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Umang Jain <umang.jain@ideasonboard.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Ray Jui <rjui@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/3] Revert "staging: mmal-vchiq: Avoid use of bool in structures"
Date: Fri, 18 Nov 2022 11:35:52 +0300 [thread overview]
Message-ID: <Y3dD6Lg2L7CgkDFe@kadam> (raw)
In-Reply-To: <Y3bN8I7DlxRUZumH@lunn.ch>
On Fri, Nov 18, 2022 at 01:12:32AM +0100, Andrew Lunn wrote:
>
> Does :1 really initialise the variable?
Obviously not.
> In "u32 enabled:1" it means
> this is a 1 bit wide bit field. It seems odd that bool is somehow
> special and :1 means something else.
If you have a bunch of consecutive bool a:1; bool b:1; then GCC will
squeeze them into the same byte. But if you have bool a; bool b; then
they each take a byte with GCC. I have specified GCC because the size
of bool types are a bit vague in the C standard.
regards,
dan carpenter
next prev parent reply other threads:[~2022-11-18 8:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 16:00 [PATCH 0/3] vc04_services: Promote bool usage Umang Jain
2022-11-17 16:00 ` [PATCH 1/3] Revert "staging: mmal-vchiq: Avoid use of bool in structures" Umang Jain
2022-11-17 16:09 ` Kieran Bingham
2022-11-17 17:55 ` Umang Jain
2022-11-17 18:02 ` Greg Kroah-Hartman
2022-11-17 18:22 ` Umang Jain
2022-11-18 0:12 ` Andrew Lunn
2022-11-18 3:58 ` Umang Jain
2022-11-18 8:35 ` Dan Carpenter [this message]
2022-11-17 16:00 ` [PATCH 2/3] vc04_services: mmal-vchiq: Use bool for vchiq_mmal_component.in_use Umang Jain
2022-11-18 0:23 ` Andrew Lunn
2022-11-18 9:01 ` Dan Carpenter
2022-11-17 16:00 ` [PATCH 3/3] vc04_services: bcm2835-camera: Use bool values for mmal_fmt.remove_padding Umang Jain
2022-11-17 18:11 ` [PATCH 0/3] vc04_services: Promote bool usage Stefan Wahren
2022-11-18 8:47 ` Dan Carpenter
2022-11-18 17:25 ` Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3dD6Lg2L7CgkDFe@kadam \
--to=error27@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab+samsung@kernel.org \
--cc=rjui@broadcom.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox