From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3B9110798 for ; Mon, 21 Nov 2022 23:11:00 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0709B88F; Tue, 22 Nov 2022 00:10:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669072258; bh=ICJPXGJqDl9B3gvjBQthmk++7OSwnmdB2if8+GkFegI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c0fewawBZ8Edft7Kcnd4/D7sloM4SAArROsqUQe7gH6bug4V0LnxLG7Fa3I0kRmBc fWLWNTkZ3qskp3V5whidiHdjwUfL808skXA+CtcC7i1UQJSqSYNPO+BracngmUr2Tg nuOmpRnfn88GdxKjefvPsM/IFBBvIUuXYWmCT/rw= Date: Tue, 22 Nov 2022 01:10:42 +0200 From: Laurent Pinchart To: Umang Jain Cc: linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Broadcom internal kernel review list , Dave Stevenson , Florian Fainelli , Naushir Patuck , David Plowman , Kieran Bingham Subject: Re: [PATCH 14/14] staging: vc04_services: vchiq: Load bcm2835_isp driver from vchiq Message-ID: References: <20221121214722.22563-1-umang.jain@ideasonboard.com> <20221121214722.22563-15-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221121214722.22563-15-umang.jain@ideasonboard.com> Hi Umang and Naush, Thank you for the patch. On Tue, Nov 22, 2022 at 03:17:22AM +0530, Umang Jain wrote: > From: Naushir Patuck > > bcmn2835_isp is a platform driver dependent on vchiq, > therefore add the load/unload functions for it to vchiq. The commit message mentiones a platform driver, but the code handles a platform device. The rest looks fine to me. > Signed-off-by: Naushir Patuck > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 642fdbc0d654..2d070f80a170 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -67,6 +67,7 @@ struct vchiq_state g_state; > > static struct platform_device *bcm2835_camera; > static struct platform_device *bcm2835_audio; > +static struct platform_device *bcm2835_isp; > static struct platform_device *vcsm_cma; > > struct vchiq_drvdata { > @@ -1836,6 +1837,7 @@ static int vchiq_probe(struct platform_device *pdev) > vcsm_cma = vchiq_register_child(pdev, "vcsm-cma"); > bcm2835_camera = vchiq_register_child(pdev, "bcm2835-camera"); > bcm2835_audio = vchiq_register_child(pdev, "bcm2835_audio"); > + bcm2835_isp = vchiq_register_child(pdev, "bcm2835-isp"); > > return 0; > > @@ -1847,6 +1849,7 @@ static int vchiq_probe(struct platform_device *pdev) > > static int vchiq_remove(struct platform_device *pdev) > { > + platform_device_unregister(bcm2835_isp); > platform_device_unregister(bcm2835_audio); > platform_device_unregister(bcm2835_camera); > platform_device_unregister(vcsm_cma); -- Regards, Laurent Pinchart