From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BBDE1079F for ; Mon, 21 Nov 2022 23:22:13 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B12388F; Tue, 22 Nov 2022 00:22:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669072931; bh=4rD0mH/nQMz3jhYfYvSCQW+AjpQxc5wuB3zU0+3GzBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pYMdMiPl5IrORg/CnguFQwPxjYBCJXu3p5rszsx4+nBwcHfMtcZvG4QwzXlP8mU2a jhexLoWbFLy+osr9fnKJT1ly2Zz8LEiUvYL+Qb0Z/UUW3E7zpR4geuQbqUnNpOyF8u y/ctkgREjNe4OrG1xkTGPbURlsuP6zPNvV/Hk90E= Date: Tue, 22 Nov 2022 01:21:56 +0200 From: Laurent Pinchart To: Umang Jain Cc: linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Broadcom internal kernel review list , Dave Stevenson , Florian Fainelli , Naushir Patuck , David Plowman , Kieran Bingham Subject: Re: [PATCH 06/14] staging: mmal_vchiq: Add image formats to be used by bcm2835-isp Message-ID: References: <20221121214722.22563-1-umang.jain@ideasonboard.com> <20221121214722.22563-7-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221121214722.22563-7-umang.jain@ideasonboard.com> Hi Umang and Dave, Thank you for the patch. On Tue, Nov 22, 2022 at 03:17:14AM +0530, Umang Jain wrote: > From: Dave Stevenson > > The bcm2835-isp supports Bayer, so add in the encodings for them. > Also, Add support for monochrome image formats in the various MIPI > packings. > > Signed-off-by: Dave Stevenson > Signed-off-by: Umang Jain > --- > .../vc04_services/vchiq-mmal/mmal-encodings.h | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-encodings.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-encodings.h > index e15ae7b24f73..4711877a9711 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-encodings.h > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-encodings.h > @@ -69,6 +69,68 @@ > */ > #define MMAL_ENCODING_OPAQUE MMAL_FOURCC('O', 'P', 'Q', 'V') > > +/* Bayer formats /* * Bayer formats > + * FourCC values copied from V4L2 where defined. > + */ > +/* 8 bit per pixel Bayer formats. */ > +#define MMAL_ENCODING_BAYER_SBGGR8 MMAL_FOURCC('B', 'A', '8', '1') > +#define MMAL_ENCODING_BAYER_SGBRG8 MMAL_FOURCC('G', 'B', 'R', 'G') > +#define MMAL_ENCODING_BAYER_SGRBG8 MMAL_FOURCC('G', 'R', 'B', 'G') > +#define MMAL_ENCODING_BAYER_SRGGB8 MMAL_FOURCC('R', 'G', 'G', 'B') > + > +/* 10 bit per pixel packed Bayer formats. */ > +#define MMAL_ENCODING_BAYER_SBGGR10P MMAL_FOURCC('p', 'B', 'A', 'A') > +#define MMAL_ENCODING_BAYER_SGRBG10P MMAL_FOURCC('p', 'g', 'A', 'A') > +#define MMAL_ENCODING_BAYER_SGBRG10P MMAL_FOURCC('p', 'G', 'A', 'A') SGBRG should go before SGRBG, like for the raw 8 formats. Same below for the 12P, 10 and 12 formats. Reviewed-by: Laurent Pinchart > +#define MMAL_ENCODING_BAYER_SRGGB10P MMAL_FOURCC('p', 'R', 'A', 'A') > + > +/* 12 bit per pixel packed Bayer formats. */ > +#define MMAL_ENCODING_BAYER_SBGGR12P MMAL_FOURCC('p', 'B', '1', '2') > +#define MMAL_ENCODING_BAYER_SGRBG12P MMAL_FOURCC('p', 'g', '1', '2') > +#define MMAL_ENCODING_BAYER_SGBRG12P MMAL_FOURCC('p', 'G', '1', '2') > +#define MMAL_ENCODING_BAYER_SRGGB12P MMAL_FOURCC('p', 'R', '1', '2') > + > +/* 14 bit per pixel Bayer formats. */ > +#define MMAL_ENCODING_BAYER_SBGGR14P MMAL_FOURCC('p', 'B', 'E', 'E') > +#define MMAL_ENCODING_BAYER_SGBRG14P MMAL_FOURCC('p', 'G', 'E', 'E') > +#define MMAL_ENCODING_BAYER_SGRBG14P MMAL_FOURCC('p', 'g', 'E', 'E') > +#define MMAL_ENCODING_BAYER_SRGGB14P MMAL_FOURCC('p', 'R', 'E', 'E') > + > +/* 16 bit per pixel Bayer formats. */ > +#define MMAL_ENCODING_BAYER_SBGGR16 MMAL_FOURCC('B', 'G', '1', '6') > +#define MMAL_ENCODING_BAYER_SGBRG16 MMAL_FOURCC('G', 'B', '1', '6') > +#define MMAL_ENCODING_BAYER_SGRBG16 MMAL_FOURCC('G', 'R', '1', '6') > +#define MMAL_ENCODING_BAYER_SRGGB16 MMAL_FOURCC('R', 'G', '1', '6') > + > +/* 10 bit per pixel unpacked (16bit) Bayer formats. */ > +#define MMAL_ENCODING_BAYER_SBGGR10 MMAL_FOURCC('B', 'G', '1', '0') > +#define MMAL_ENCODING_BAYER_SGRBG10 MMAL_FOURCC('B', 'A', '1', '0') > +#define MMAL_ENCODING_BAYER_SGBRG10 MMAL_FOURCC('G', 'B', '1', '0') > +#define MMAL_ENCODING_BAYER_SRGGB10 MMAL_FOURCC('R', 'G', '1', '0') > + > +/* 12 bit per pixel unpacked (16bit) Bayer formats */ > +#define MMAL_ENCODING_BAYER_SBGGR12 MMAL_FOURCC('B', 'G', '1', '2') > +#define MMAL_ENCODING_BAYER_SGRBG12 MMAL_FOURCC('B', 'A', '1', '2') > +#define MMAL_ENCODING_BAYER_SGBRG12 MMAL_FOURCC('G', 'B', '1', '2') > +#define MMAL_ENCODING_BAYER_SRGGB12 MMAL_FOURCC('R', 'G', '1', '2') > + > +/* 14 bit per pixel unpacked (16bit) Bayer formats */ > +#define MMAL_ENCODING_BAYER_SBGGR14 MMAL_FOURCC('B', 'G', '1', '4') > +#define MMAL_ENCODING_BAYER_SGBRG14 MMAL_FOURCC('G', 'B', '1', '4') > +#define MMAL_ENCODING_BAYER_SGRBG14 MMAL_FOURCC('G', 'R', '1', '4') > +#define MMAL_ENCODING_BAYER_SRGGB14 MMAL_FOURCC('R', 'G', '1', '4') > + > +/* MIPI packed monochrome images */ > +#define MMAL_ENCODING_GREY MMAL_FOURCC('G', 'R', 'E', 'Y') > +#define MMAL_ENCODING_Y10P MMAL_FOURCC('Y', '1', '0', 'P') > +#define MMAL_ENCODING_Y12P MMAL_FOURCC('Y', '1', '2', 'P') > +#define MMAL_ENCODING_Y14P MMAL_FOURCC('Y', '1', '4', 'P') > +#define MMAL_ENCODING_Y16 MMAL_FOURCC('Y', '1', '6', ' ') > +/* Unpacked monochrome formats (16bit per sample, but only N LSBs used) */ > +#define MMAL_ENCODING_Y10 MMAL_FOURCC('Y', '1', '0', ' ') > +#define MMAL_ENCODING_Y12 MMAL_FOURCC('Y', '1', '2', ' ') > +#define MMAL_ENCODING_Y14 MMAL_FOURCC('Y', '1', '4', ' ') > + > /** An EGL image handle > */ > #define MMAL_ENCODING_EGL_IMAGE MMAL_FOURCC('E', 'G', 'L', 'I') -- Regards, Laurent Pinchart