From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF4410E8 for ; Thu, 1 Dec 2022 07:17:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C057C433D6; Thu, 1 Dec 2022 07:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669879022; bh=PrKICSTOmcGLJ/BB8PIwEFn3Kaj9T9r7mow24i0Oobc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uumwS904EL9Ut/AAu8n9jhiOls2CBOTQvzu0hnyR0cAO31xm3hko/NVKsSTCM+Qri /Cc7twuom20PD8xOUAMwqDjUJGqt67MUVMreuW3Hv+brc1Apb2ZoV02s3+yNx2dBTV eZcDodtfONz09kpKl53F8c3xo3pIfOCrGNp1ZRyPW71u4vR73glY6l9x9E9HIbVC6a aZ2uVcLyHmXEbSRavTbvnNOzcxpuv0xgmLiijI1GQFgkRZiU961EyCJDE16uoXvJBg RBJrU272tG/Ud36bgqhF3QpE3rJfr3MGFp/9YEWHTeI1FOZLuIuPd6jwgTy4IeiSOZ iLDe2XM1cr7gQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1p0dog-0007lW-Sz; Thu, 01 Dec 2022 08:17:07 +0100 Date: Thu, 1 Dec 2022 08:17:06 +0100 From: Johan Hovold To: Jack Schofield Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] staging: greybus: Cleanups in loopback_test Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Nov 30, 2022 at 09:38:49PM -0800, Jack Schofield wrote: > Correct issues found by checkpatch. > > Jack Schofield (3): > staging: greybus: loopback_test: Add blank line after declaration. Nit: no need for a full stop in the commit summary. > staging: greybus: loopback_test: Remove void function return statement > staging: greybus: loopback_test: Remove extra blank lines > > drivers/staging/greybus/tools/loopback_test.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) Other than that, all of these look good to me: Reviewed-by: Johan Hovold Johan