From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 417B28F63 for ; Fri, 23 Dec 2022 15:25:24 +0000 (UTC) Received: by mail-wr1-f44.google.com with SMTP id z10so4848184wrh.10 for ; Fri, 23 Dec 2022 07:25:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I02zLCc3L9Vr4Pgf+3/wKwOrK6n4hccBX4ktlYit2UY=; b=c4m4X9M/xPPNj/v8+Kkf5y5+5BSX4GZSZ2151sK2+8N+AEWubxmGRYPTrRLPrHKElv e3720UnRSAhwxH7PGsgPDAqmEm+A8uZcvWt19GfXhy0ZCjkZyG5V834cyKAL/EyMSiwn FRShKo9mDwO2MF/lxe6pUFP8z8QpE5mZfjXidStD8FXbA//Wsm9XHewUxgfOFso9EJ01 7o7LXeAuxs5ClqlWHoKIEKEDgAMf/QZekAHdn0vh4XMjbY0+LKrpDBq/FqZbH45YCTZd /N4X9FuPGcF6vKF+tWQ5xCsy5RrVKS7S72SrHz0f07vUuWTe9uOZMcisYIX4w2vgTylq V7pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I02zLCc3L9Vr4Pgf+3/wKwOrK6n4hccBX4ktlYit2UY=; b=D3v9F0pINyz3ueafNAO9yVoSu3fPhGrZqFBJ8lVNyGFGZ2GXwgpTYJJmXPeyeGSgTy 9RZ9JKuH3Bj+9CoJfwZ1oBUVGW0TL1ztkR3mKF65YAEpPi/Ge3NVxty+couViYHCr00B nwM/BVEZF7bb45dPIe2++ccKUCnyfQcmIPb0AEPTJAp4lJmJ1546DqERHt8qV3iCZX5O MIyTsc7NED6JMLDVvoENjwwtjGyxHFdWt7tsYxiVkqJk62ur59jJealoNJ09Ofoj+8tI H11tG02bZIxO7iZepyRJ3esGTFUlYFRty9rTdfbx+cDMgPqV/pVCqafRupxxpret5Wr6 YkvA== X-Gm-Message-State: AFqh2kp/5cYcLLF8z2ErGX8ds3M6rrsW/ZusNzvA60+7/1JpiTUtIjrt VkSS29GP1ei42VogC9P0sSw= X-Google-Smtp-Source: AMrXdXtuhXBuZ5KqjB11un5Uda/BfZM3z+g/fpqt+KxkiSy1KgNZR1aeMy4s9hQ0phETTkGG2JhVBQ== X-Received: by 2002:adf:f04d:0:b0:268:2ab2:baa4 with SMTP id t13-20020adff04d000000b002682ab2baa4mr6416249wro.54.1671809122439; Fri, 23 Dec 2022 07:25:22 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id i13-20020a5d558d000000b00241e5b917d0sm4013973wrv.36.2022.12.23.07.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Dec 2022 07:25:21 -0800 (PST) Date: Fri, 23 Dec 2022 18:25:18 +0300 From: Dan Carpenter To: Stefan Wahren Cc: Umang Jain , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dave Stevenson , Kieran Bingham , Laurent Pinchart Subject: Re: [PATCH v2 5/7] vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect Message-ID: References: <20221219115725.11992-1-umang.jain@ideasonboard.com> <20221219115725.11992-6-umang.jain@ideasonboard.com> <8fcbdf54-98ae-6a06-ecaf-591a43b863a1@i2se.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8fcbdf54-98ae-6a06-ecaf-591a43b863a1@i2se.com> On Thu, Dec 22, 2022 at 12:07:56PM +0100, Stefan Wahren wrote: > Hi Umang, > > Am 19.12.22 um 12:57 schrieb Umang Jain: > > Drop the usage of VCHIQ_RETRY when the vchiq has connection status > > VCHIQ_CONNSTATE_DISCONNECTED. Disconnected status will not be valid to > > carry on a retry, replace the VCHIQ_RETRY with -ENOTCONN. > > > > This patch removes the usage of vCHIQ_RETRY completely and act as > > intermediatory to address the TODO item: > > * Get rid of custom function return values > > for vc04_services/interface. > > > > Fixes: 71bad7f08641 ("staging: add bcm2708 vchiq driver") > please drop this fixes tag since this commit doesn't fix a real issue and > also shouldn't be applied to stable. I asked Umang to add the Fixes tag based on the patch description and based on that it seemed like a behavior change just from looking at the patch. But actually you are right that the fixes tag is not required. The vchiq_send_remote_use() function is never called (dead code). The vchiq_send_remote_use_active() function now returns a mix of custom error codes and negative error codes. (Ugly). The caller only tests for VCHIQ_SUCCESS so this code does not change behavior. I really feel like the commit description needs to be clearer on this. The fixes tag is not really about stable. Stable uses the tag, but the fixes tag is appropriate whenever there is a bug fix. regards, dan carpenter