From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C03D13209 for ; Wed, 11 Jan 2023 16:54:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EC4BC433D2; Wed, 11 Jan 2023 16:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673456082; bh=mXESQehV0wt8kRi6/+LpO/EWbusEEZr0NKPtbWhQXkk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NZ2n4T9WAfM31GVkMr0U+OYQ1Le0CO4szDFcbo43kBez/1J9qnZ9YKq8esW75ezAZ 8JfUAS86yxHZ9RhJ0V0pNmj/VY/ORz9S6fCeFssGIrcuF1Xfq9yUTkn3I4Is0Wx2Mc NFzsNx9oyDWOwe61DNPL38/EqDVkfCeFJN2jUfno83iUYhu70LDJ+1tw4eGExWbpbY EOSUDeG+tMj/l65lE9dJr/seo+5C+OIm0cRJdutUZSTltGuxSufv6PYLoSM27KZI6v 4KVn8oRKJo1GTkXYra54pA1zq+/IHJ9a5qCkOem0Z3aiYG9t9YXNKYj154cUDU8BE7 E8CK13X7gSsBA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pFeN6-0003YU-Rv; Wed, 11 Jan 2023 17:54:41 +0100 Date: Wed, 11 Jan 2023 17:54:40 +0100 From: Johan Hovold To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Samuel Iglesias =?utf-8?Q?Gons=C3=A1lvez?= , Rodolfo Giometti , Arnd Bergmann , Ulf Hansson , David Lin , Alex Elder , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 11/13] tty/serial: Call ->dtr_rts() parameter active consistently Message-ID: References: <20230111142331.34518-1-ilpo.jarvinen@linux.intel.com> <20230111142331.34518-12-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230111142331.34518-12-ilpo.jarvinen@linux.intel.com> On Wed, Jan 11, 2023 at 04:23:29PM +0200, Ilpo Järvinen wrote: > Convert various parameter names for ->dtr_rts() and related functions > from onoff, on, and raise to active. > > Reviewed-by: Jiri Slaby > Signed-off-by: Ilpo Järvinen > --- > drivers/char/pcmcia/synclink_cs.c | 6 +++--- > drivers/mmc/core/sdio_uart.c | 6 +++--- > drivers/staging/greybus/uart.c | 4 ++-- > drivers/tty/amiserial.c | 4 ++-- > drivers/tty/hvc/hvc_console.h | 2 +- > drivers/tty/hvc/hvc_iucv.c | 6 +++--- > drivers/tty/mxser.c | 4 ++-- > drivers/tty/n_gsm.c | 4 ++-- > drivers/tty/serial/serial_core.c | 8 ++++---- > drivers/tty/synclink_gt.c | 4 ++-- > include/linux/tty_port.h | 4 ++-- > include/linux/usb/serial.h | 2 +- > 12 files changed, 27 insertions(+), 27 deletions(-) > diff --git a/include/linux/tty_port.h b/include/linux/tty_port.h > index c44e489de0ff..edf685a24f7c 100644 > --- a/include/linux/tty_port.h > +++ b/include/linux/tty_port.h > @@ -16,7 +16,7 @@ struct tty_struct; > /** > * struct tty_port_operations -- operations on tty_port > * @carrier_raised: return true if the carrier is raised on @port > - * @dtr_rts: raise the DTR line if @raise is true, otherwise lower DTR > + * @dtr_rts: raise the DTR line if @active is true, otherwise lower DTR > * @shutdown: called when the last close completes or a hangup finishes IFF the > * port was initialized. Do not use to free resources. Turn off the device > * only. Called under the port mutex to serialize against @activate and > @@ -32,7 +32,7 @@ struct tty_struct; > */ > struct tty_port_operations { > bool (*carrier_raised)(struct tty_port *port); > - void (*dtr_rts)(struct tty_port *port, bool raise); > + void (*dtr_rts)(struct tty_port *port, bool active); > void (*shutdown)(struct tty_port *port); > int (*activate)(struct tty_port *port, struct tty_struct *tty); > void (*destruct)(struct tty_port *port); > diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h > index bad343c5e8a7..33afd9f3ebbe 100644 > --- a/include/linux/usb/serial.h > +++ b/include/linux/usb/serial.h > @@ -292,7 +292,7 @@ struct usb_serial_driver { > struct serial_icounter_struct *icount); > /* Called by the tty layer for port level work. There may or may not > be an attached tty at this point */ > - void (*dtr_rts)(struct usb_serial_port *port, bool on); > + void (*dtr_rts)(struct usb_serial_port *port, bool active); This is not a tty_port callback so this change does not belong in this patch. > bool (*carrier_raised)(struct usb_serial_port *port); > /* Called by the usb serial hooks to allow the user to rework the > termios state */ Johan