From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42FD5EC5; Thu, 5 Jan 2023 10:02:26 +0000 (UTC) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 2EF42E000E; Thu, 5 Jan 2023 10:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1672912937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QZFL3qyTfHdN27paTVk6oqvr7A5Y7FRlExyKi8NGY5A=; b=o4lTnWDk/szT4G1LfYqkSGS/fTFhsasemGRIT4uKl+cIl4ndNTOnOPODlQma6sxBn/SJdb 08+0rToEL+FASQlNczHSf/1WUG4hz1DtEu1/DU8vNgmtk0j5WnhFdrDWpsV8huqsTBk0yj npDIoEJCvzLHraUFlV4XvQCDsYlPVStQSiRFFF+4M+DF9w6rdTjjVHFSR89IwCoKn6rf6F t5MiJ5qpno8DJMczerKiyshDJ1lcuwEWPhxtGQREq5kdu5s0hShD3qicJ9CwhNAfRkZHP3 zE0pbq8+87tEUeKEmscQ5nfAPD1HNcLYZ88iZFFp5HT/egQnJgo8z/7T+viUYw== Date: Thu, 5 Jan 2023 11:02:12 +0100 From: Paul Kocialkowski To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Albert Ou , Conor Dooley , Greg Kroah-Hartman , Maxime Ripard , Palmer Dabbelt , Paul Walmsley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-riscv@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 3/4] media: cedrus: Make SRAM section claiming optional Message-ID: References: <20221231164628.19688-1-samuel@sholland.org> <20221231164628.19688-4-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8/6s3dcqSbgka7v/" Content-Disposition: inline In-Reply-To: <20221231164628.19688-4-samuel@sholland.org> --8/6s3dcqSbgka7v/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Samuel, On Sat 31 Dec 22, 10:46, Samuel Holland wrote: > The video engine in the D1 family of SoCs does not have a switchable > SRAM section. Allow the driver to probe even when the SRAM section > reference is missing. >=20 > Signed-off-by: Samuel Holland Looks good, I've also just checked that calling sunxi_sram_release with no reference to the SRAM held is fine (maybe a word about it in the commit log would be nice, but probably not worth making a v2 just for that). Reviewed-by: Paul Kocialkowski Cheers, Paul > --- >=20 > drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/sta= ging/media/sunxi/cedrus/cedrus_hw.c > index fa86a658fdc6..11e859617932 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > @@ -257,7 +257,7 @@ int cedrus_hw_probe(struct cedrus_dev *dev) > } > =20 > ret =3D sunxi_sram_claim(dev->dev); > - if (ret) { > + if (ret && ret !=3D -ENOENT) { > dev_err(dev->dev, "Failed to claim SRAM\n"); > =20 > goto err_mem; > --=20 > 2.37.4 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --8/6s3dcqSbgka7v/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmO2oCQACgkQ3cLmz3+f v9GdzQf7BBo2ZY1agypl/4WFck7Oxw+wz2H294juvEYfBbZWII+esDVDHiBUiZaw +iQVeT7ZGMum5E0Mvg+oaLduGhB271eZKHNY/YnEM3NHlwwUvy9TUJhR0iuKrX1H rLf4NGQrmXAfBVnrnlW2ROIC3kz9DcRwC/busmLyMk025CMM54AlmY0Y8XaiMThq ic6BTgL9b8a17lwg5G66A9OMNB8ee4WCfssFQ7kriVmFH644tTgtrFS8azGBCsI1 cxA7JGvZJWuJEm9L8PDMDvOm3IAC0djIgJ9gqkbJdCaJqW9H5c6iJBoFOJID6g2l 1SmqmlYcNehm79PXDFiAc9Xpq+Brfw== =2Hd+ -----END PGP SIGNATURE----- --8/6s3dcqSbgka7v/--