From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
Yury Luneff <yury.lunev@gmail.com>,
Nable <nable.maininbox@googlemail.com>,
andrey.i.trufanov@gmail.com, Fabio Aiuto <fabioaiuto83@gmail.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 40/57] media: atomisp: ov2680: Drop struct ov2680_resolution / ov2680_res_preview
Date: Tue, 24 Jan 2023 12:44:52 +0200 [thread overview]
Message-ID: <Y8+2pOGesbxkvWOC@smile.fi.intel.com> (raw)
In-Reply-To: <20230123125205.622152-41-hdegoede@redhat.com>
On Mon, Jan 23, 2023 at 01:51:48PM +0100, Hans de Goede wrote:
> Drop struct ov2680_resolution and the ov2680_res_preview[] array,
> this is now only used in ov2680_enum_frame_size() and only
> the width + height are used there.
>
> Replace this with a new struct v4l2_frmsize_discrete ov2680_frame_sizes[]
> array.
>
> No functional changes.
Makes sense,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> .../media/atomisp/i2c/atomisp-ov2680.c | 24 +-
> drivers/staging/media/atomisp/i2c/ov2680.h | 610 ------------------
> 2 files changed, 19 insertions(+), 615 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> index 3d5e18fb45ee..432539dd274c 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> @@ -698,15 +698,29 @@ static int ov2680_enum_frame_size(struct v4l2_subdev *sd,
> struct v4l2_subdev_state *sd_state,
> struct v4l2_subdev_frame_size_enum *fse)
> {
> + static const struct v4l2_frmsize_discrete ov2680_frame_sizes[] = {
> + { 1616, 1216 },
> + { 1616, 1082 },
> + { 1616, 916 },
> + { 1456, 1096 },
> + { 1296, 976 },
> + { 1296, 736 },
> + { 800, 600 },
> + { 720, 592 },
> + { 656, 496 },
> + { 336, 256 },
> + { 352, 288 },
> + { 176, 144 },
> + };
> int index = fse->index;
>
> - if (index >= N_RES_PREVIEW)
> + if (index >= ARRAY_SIZE(ov2680_frame_sizes))
> return -EINVAL;
>
> - fse->min_width = ov2680_res_preview[index].width;
> - fse->min_height = ov2680_res_preview[index].height;
> - fse->max_width = ov2680_res_preview[index].width;
> - fse->max_height = ov2680_res_preview[index].height;
> + fse->min_width = ov2680_frame_sizes[index].width;
> + fse->min_height = ov2680_frame_sizes[index].height;
> + fse->max_width = ov2680_frame_sizes[index].width;
> + fse->max_height = ov2680_frame_sizes[index].height;
>
> return 0;
> }
> diff --git a/drivers/staging/media/atomisp/i2c/ov2680.h b/drivers/staging/media/atomisp/i2c/ov2680.h
> index e9d0c84705fb..20ef59928cb1 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2680.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2680.h
> @@ -154,18 +154,6 @@ struct regval_list {
> u8 value;
> };
>
> -struct ov2680_resolution {
> - const struct ov2680_reg *regs;
> - int res;
> - int width;
> - int height;
> - int fps;
> - int pix_clk_freq;
> - u32 skip_frames;
> - u16 pixels_per_line;
> - u16 lines_per_frame;
> -};
> -
> struct ov2680_format {
> u8 *desc;
> u32 pixelformat;
> @@ -320,602 +308,4 @@ static struct ov2680_reg const ov2680_global_setting[] = {
> {}
> };
>
> -/*
> - * 176x144 30fps VBlanking 1lane 10Bit (binning)
> - */
> -static struct ov2680_reg const ov2680_QCIF_30fps[] = {
> - {0x3086, 0x01},
> - {0x370a, 0x23},
> - {0x3801, 0xa0},
> - {0x3802, 0x00},
> - {0x3803, 0x78},
> - {0x3804, 0x05},
> - {0x3805, 0xaf},
> - {0x3806, 0x04},
> - {0x3807, 0x47},
> - {0x3808, 0x00},
> - {0x3809, 0xC0},
> - {0x380a, 0x00},
> - {0x380b, 0xa0},
> - {0x380c, 0x06},
> - {0x380d, 0xb0},
> - {0x3810, 0x00},
> - {0x3811, 0x04},
> - {0x3812, 0x00},
> - {0x3813, 0x04},
> - {0x3814, 0x31},
> - {0x3815, 0x31},
> - {0x4000, 0x81},
> - {0x4001, 0x40},
> - {0x4008, 0x00},
> - {0x4009, 0x03},
> - {0x5081, 0x41},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x00},
> - {0x5705, 0xc0},
> - {0x5706, 0x00},
> - {0x5707, 0xa0},
> - {0x3820, 0xc2},
> - {0x3821, 0x01},
> - // {0x5090, 0x0c},
> - {}
> -};
> -
> -/*
> - * 352x288 30fps VBlanking 1lane 10Bit (binning)
> - */
> -static struct ov2680_reg const ov2680_CIF_30fps[] = {
> - {0x3086, 0x01},
> - {0x370a, 0x23},
> - {0x3801, 0xa0},
> - {0x3802, 0x00},
> - {0x3803, 0x78},
> - {0x3804, 0x03},
> - {0x3805, 0x8f},
> - {0x3806, 0x02},
> - {0x3807, 0xe7},
> - {0x3808, 0x01},
> - {0x3809, 0x70},
> - {0x380a, 0x01},
> - {0x380b, 0x30},
> - {0x380c, 0x06},
> - {0x380d, 0xb0},
> - {0x3810, 0x00},
> - {0x3811, 0x04},
> - {0x3812, 0x00},
> - {0x3813, 0x04},
> - {0x3814, 0x31},
> - {0x3815, 0x31},
> - {0x4008, 0x00},
> - {0x4009, 0x03},
> - {0x5081, 0x41},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x01},
> - {0x5705, 0x70},
> - {0x5706, 0x01},
> - {0x5707, 0x30},
> - {0x3820, 0xc2},
> - {0x3821, 0x01},
> - // {0x5090, 0x0c},
> - {}
> -};
> -
> -/*
> - * 336x256 30fps VBlanking 1lane 10Bit (binning)
> - */
> -static struct ov2680_reg const ov2680_QVGA_30fps[] = {
> - {0x3086, 0x01},
> - {0x370a, 0x23},
> - {0x3801, 0xa0},
> - {0x3802, 0x00},
> - {0x3803, 0x78},
> - {0x3804, 0x03},
> - {0x3805, 0x4f},
> - {0x3806, 0x02},
> - {0x3807, 0x87},
> - {0x3808, 0x01},
> - {0x3809, 0x50},
> - {0x380a, 0x01},
> - {0x380b, 0x00},
> - {0x380c, 0x06},
> - {0x380d, 0xb0},
> - {0x3810, 0x00},
> - {0x3811, 0x04},
> - {0x3812, 0x00},
> - {0x3813, 0x04},
> - {0x3814, 0x31},
> - {0x3815, 0x31},
> - {0x4008, 0x00},
> - {0x4009, 0x03},
> - {0x5081, 0x41},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x01},
> - {0x5705, 0x50},
> - {0x5706, 0x01},
> - {0x5707, 0x00},
> - {0x3820, 0xc2},
> - {0x3821, 0x01},
> - // {0x5090, 0x0c},
> - {}
> -};
> -
> -/*
> - * 656x496 30fps VBlanking 1lane 10Bit (binning)
> - */
> -static struct ov2680_reg const ov2680_656x496_30fps[] = {
> - {0x3086, 0x01},
> - {0x370a, 0x23},
> - {0x3801, 0xa0},
> - {0x3802, 0x00},
> - {0x3803, 0x78},
> - {0x3804, 0x05},
> - {0x3805, 0xcf},
> - {0x3806, 0x04},
> - {0x3807, 0x67},
> - {0x3808, 0x02},
> - {0x3809, 0x90},
> - {0x380a, 0x01},
> - {0x380b, 0xf0},
> - {0x380c, 0x06},
> - {0x380d, 0xb0},
> - {0x3810, 0x00},
> - {0x3811, 0x04},
> - {0x3812, 0x00},
> - {0x3813, 0x04},
> - {0x3814, 0x31},
> - {0x3815, 0x31},
> - {0x4008, 0x00},
> - {0x4009, 0x03},
> - {0x5081, 0x41},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x02},
> - {0x5705, 0x90},
> - {0x5706, 0x01},
> - {0x5707, 0xf0},
> - {0x3820, 0xc2},
> - {0x3821, 0x01},
> - // {0x5090, 0x0c},
> - {}
> -};
> -
> -/*
> - * 720x592 30fps VBlanking 1lane 10Bit (binning)
> - */
> -static struct ov2680_reg const ov2680_720x592_30fps[] = {
> - {0x3086, 0x01},
> - {0x370a, 0x23},
> - {0x3801, 0x00}, // X_ADDR_START;
> - {0x3802, 0x00},
> - {0x3803, 0x00}, // Y_ADDR_START;
> - {0x3804, 0x05},
> - {0x3805, 0xaf}, // X_ADDR_END;
> - {0x3806, 0x04},
> - {0x3807, 0xaf}, // Y_ADDR_END;
> - {0x3808, 0x02},
> - {0x3809, 0xd0}, // X_OUTPUT_SIZE;
> - {0x380a, 0x02},
> - {0x380b, 0x50}, // Y_OUTPUT_SIZE;
> - {0x380c, 0x06},
> - {0x380d, 0xac}, // HTS;
> - {0x3810, 0x00},
> - {0x3811, 0x00},
> - {0x3812, 0x00},
> - {0x3813, 0x00},
> - {0x3814, 0x31},
> - {0x3815, 0x31},
> - {0x4008, 0x00},
> - {0x4009, 0x03},
> - {0x5708, 0x01},
> - {0x5704, 0x02},
> - {0x5705, 0xd0}, // X_WIN;
> - {0x5706, 0x02},
> - {0x5707, 0x50}, // Y_WIN;
> - {0x3820, 0xc2}, // FLIP_FORMAT;
> - {0x3821, 0x01}, // MIRROR_FORMAT;
> - {0x5090, 0x00}, // PRE ISP CTRL16, default value is 0x0C;
> - // BIT[3]: Mirror order, BG or GB;
> - // BIT[2]: Flip order, BR or RB;
> - {0x5081, 0x41},
> - {}
> -};
> -
> -/*
> - * 800x600 30fps VBlanking 1lane 10Bit (binning)
> - */
> -static struct ov2680_reg const ov2680_800x600_30fps[] = {
> - {0x3086, 0x01},
> - {0x370a, 0x23},
> - {0x3801, 0x00}, /* hstart 0 */
> - {0x3802, 0x00},
> - {0x3803, 0x00}, /* vstart 0 */
> - {0x3804, 0x06},
> - {0x3805, 0x4f}, /* hend 1615 */
> - {0x3806, 0x04},
> - {0x3807, 0xbf}, /* vend 1215 */
> - {0x3808, 0x03},
> - {0x3809, 0x20}, /* hsize 800 */
> - {0x380a, 0x02},
> - {0x380b, 0x58}, /* vsize 600 */
> - {0x380c, 0x06},
> - {0x380d, 0xac}, /* htotal 1708 */
> - {0x3810, 0x00},
> - {0x3811, 0x00},
> - {0x3812, 0x00},
> - {0x3813, 0x00},
> - {0x3814, 0x31},
> - {0x3815, 0x31},
> - {0x5708, 0x01},
> - {0x5704, 0x03},
> - {0x5705, 0x20},
> - {0x5706, 0x02},
> - {0x5707, 0x58},
> - {0x3820, 0xc2},
> - {0x3821, 0x01},
> - {0x5090, 0x00},
> - {0x4008, 0x00},
> - {0x4009, 0x03},
> - {0x5081, 0x41},
> - {}
> -};
> -
> -/*
> - * 720p=1280*720 30fps VBlanking 1lane 10Bit (no-Scaling)
> - */
> -static struct ov2680_reg const ov2680_720p_30fps[] = {
> - {0x3086, 0x00},
> - {0x370a, 0x21},
> - {0x3801, 0xa0}, /* hstart 160 */
> - {0x3802, 0x00},
> - {0x3803, 0xf2}, /* vstart 242 */
> - {0x3804, 0x05},
> - {0x3805, 0xbf}, /* hend 1471 */
> - {0x3806, 0x03},
> - {0x3807, 0xdd}, /* vend 989 */
> - {0x3808, 0x05},
> - {0x3809, 0x10}, /* hsize 1296 */
> - {0x380a, 0x02},
> - {0x380b, 0xe0}, /* vsize 736 */
> - {0x380c, 0x06},
> - {0x380d, 0xa8}, /* htotal 1704 */
> - {0x3810, 0x00},
> - {0x3811, 0x08},
> - {0x3812, 0x00},
> - {0x3813, 0x06},
> - {0x3814, 0x11},
> - {0x3815, 0x11},
> - {0x4008, 0x02},
> - {0x4009, 0x09},
> - {0x5081, 0x41},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x05},
> - {0x5705, 0x10},
> - {0x5706, 0x02},
> - {0x5707, 0xe0},
> - {0x3820, 0xc0},
> - {0x3821, 0x00},
> - // {0x5090, 0x0c},
> - {}
> -};
> -
> -/*
> - * 1296x976 30fps VBlanking 1lane 10Bit(no-scaling)
> - */
> -static struct ov2680_reg const ov2680_1296x976_30fps[] = {
> - {0x3086, 0x00},
> - {0x370a, 0x21},
> - {0x3801, 0xa0}, /* hstart 160 */
> - {0x3802, 0x00},
> - {0x3803, 0x78}, /* vstart 120 */
> - {0x3804, 0x05},
> - {0x3805, 0xbf}, /* hend 1471 */
> - {0x3806, 0x04},
> - {0x3807, 0x57}, /* vend 1111 */
> - {0x3808, 0x05},
> - {0x3809, 0x10}, /* hsize 1296 */
> - {0x380a, 0x03},
> - {0x380b, 0xd0}, /* vsize 976 */
> - {0x380c, 0x06},
> - {0x380d, 0xa8}, /* htotal 1704 */
> - {0x3810, 0x00},
> - {0x3811, 0x08},
> - {0x3812, 0x00},
> - {0x3813, 0x08},
> - {0x3814, 0x11},
> - {0x3815, 0x11},
> - {0x4008, 0x02},
> - {0x4009, 0x09},
> - {0x5081, 0x41},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x05},
> - {0x5705, 0x10},
> - {0x5706, 0x03},
> - {0x5707, 0xd0},
> - {0x3820, 0xc0},
> - {0x3821, 0x00}, //mirror/flip
> - // {0x5090, 0x0c},
> - {}
> -};
> -
> -/*
> - * 1456*1096 30fps VBlanking 1lane 10bit(no-scaling)
> - */
> -static struct ov2680_reg const ov2680_1456x1096_30fps[] = {
> - {0x3086, 0x00},
> - {0x370a, 0x21},
> - {0x3801, 0x90},
> - {0x3802, 0x00},
> - {0x3803, 0x78},
> - {0x3804, 0x06},
> - {0x3805, 0x4f},
> - {0x3806, 0x04},
> - {0x3807, 0xC0},
> - {0x3808, 0x05},
> - {0x3809, 0xb0},
> - {0x380a, 0x04},
> - {0x380b, 0x48},
> - {0x380c, 0x06},
> - {0x380d, 0xa8},
> - {0x3810, 0x00},
> - {0x3811, 0x08},
> - {0x3812, 0x00},
> - {0x3813, 0x00},
> - {0x3814, 0x11},
> - {0x3815, 0x11},
> - {0x4008, 0x02},
> - {0x4009, 0x09},
> - {0x5081, 0x41},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x05},
> - {0x5705, 0xb0},
> - {0x5706, 0x04},
> - {0x5707, 0x48},
> - {0x3820, 0xc0},
> - {0x3821, 0x00},
> - // {0x5090, 0x0c},
> - {}
> -};
> -
> -/*
> - *1616x916 30fps VBlanking 1lane 10bit
> - */
> -
> -static struct ov2680_reg const ov2680_1616x916_30fps[] = {
> - {0x3086, 0x00},
> - {0x370a, 0x21},
> - {0x3801, 0x00},
> - {0x3802, 0x00},
> - {0x3803, 0x96},
> - {0x3804, 0x06},
> - {0x3805, 0x4f},
> - {0x3806, 0x04},
> - {0x3807, 0x39},
> - {0x3808, 0x06},
> - {0x3809, 0x50},
> - {0x380a, 0x03},
> - {0x380b, 0x94},
> - {0x380c, 0x06},
> - {0x380d, 0xa8},
> - {0x3810, 0x00},
> - {0x3811, 0x00},
> - {0x3812, 0x00},
> - {0x3813, 0x08},
> - {0x3814, 0x11},
> - {0x3815, 0x11},
> - {0x4008, 0x02},
> - {0x4009, 0x09},
> - {0x5081, 0x41},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x06},
> - {0x5705, 0x50},
> - {0x5706, 0x03},
> - {0x5707, 0x94},
> - {0x3820, 0xc0},
> - {0x3821, 0x00},
> - // {0x5090, 0x0C},
> - {}
> -};
> -
> -/*
> - * 1616x1082 30fps VBlanking 1lane 10Bit
> - */
> -static struct ov2680_reg const ov2680_1616x1082_30fps[] = {
> - {0x3086, 0x00},
> - {0x370a, 0x21},
> - {0x3801, 0x00},
> - {0x3802, 0x00},
> - {0x3803, 0x86},
> - {0x3804, 0x06},
> - {0x3805, 0x4f},
> - {0x3806, 0x04},
> - {0x3807, 0xbf},
> - {0x3808, 0x06},
> - {0x3809, 0x50},
> - {0x380a, 0x04},
> - {0x380b, 0x3a},
> - {0x380c, 0x06},
> - {0x380d, 0xa8},
> - {0x3810, 0x00},
> - {0x3811, 0x00},
> - {0x3812, 0x00},
> - {0x3813, 0x00},
> - {0x3814, 0x11},
> - {0x3815, 0x11},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x06},
> - {0x5705, 0x50},
> - {0x5706, 0x04},
> - {0x5707, 0x3a},
> - {0x3820, 0xc0},
> - {0x3821, 0x00},
> - // {0x5090, 0x0C},
> - {0x4008, 0x02},
> - {0x4009, 0x09},
> - {0x5081, 0x41},
> - {}
> -};
> -
> -/*
> - * 1616x1216 30fps VBlanking 1lane 10Bit
> - */
> -static struct ov2680_reg const ov2680_1616x1216_30fps[] = {
> - {0x3086, 0x00},
> - {0x370a, 0x21},
> - {0x3801, 0x00},
> - {0x3802, 0x00},
> - {0x3803, 0x00},
> - {0x3804, 0x06},
> - {0x3805, 0x4f},
> - {0x3806, 0x04},
> - {0x3807, 0xbf},
> - {0x3808, 0x06},
> - {0x3809, 0x50},//50},//4line for mirror and flip
> - {0x380a, 0x04},
> - {0x380b, 0xc0},//c0},
> - {0x380c, 0x06},
> - {0x380d, 0xa8},
> - {0x3810, 0x00},
> - {0x3811, 0x00},
> - {0x3812, 0x00},
> - {0x3813, 0x00},
> - {0x3814, 0x11},
> - {0x3815, 0x11},
> - {0x4008, 0x00},
> - {0x4009, 0x0b},
> - {0x5081, 0x01},
> - {0x5708, 0x01}, //add for full size flip off and mirror off 2014/09/11
> - {0x5704, 0x06},
> - {0x5705, 0x50},
> - {0x5706, 0x04},
> - {0x5707, 0xc0},
> - {0x3820, 0xc0},
> - {0x3821, 0x00},
> - // {0x5090, 0x0C},
> - {}
> -};
> -
> -static struct ov2680_resolution ov2680_res_preview[] = {
> - {
> - .width = 1616,
> - .height = 1216,
> - .pix_clk_freq = 66,
> - .fps = 30,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_1616x1216_30fps,
> - },
> - {
> - .width = 1616,
> - .height = 1082,
> - .pix_clk_freq = 66,
> - .fps = 30,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_1616x1082_30fps,
> - },
> - {
> - .width = 1616,
> - .height = 916,
> - .fps = 30,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_1616x916_30fps,
> - },
> - {
> - .width = 1456,
> - .height = 1096,
> - .fps = 30,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_1456x1096_30fps,
> - },
> - {
> - .width = 1296,
> - .height = 976,
> - .fps = 30,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_1296x976_30fps,
> - },
> - {
> - .width = 1296,
> - .height = 736,
> - .fps = 60,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_720p_30fps,
> - },
> - {
> - .width = 800,
> - .height = 600,
> - .fps = 60,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_800x600_30fps,
> - },
> - {
> - .width = 720,
> - .height = 592,
> - .fps = 60,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_720x592_30fps,
> - },
> - {
> - .width = 656,
> - .height = 496,
> - .fps = 60,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_656x496_30fps,
> - },
> - {
> - .width = 336,
> - .height = 256,
> - .fps = 60,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_QVGA_30fps,
> - },
> - {
> - .width = 352,
> - .height = 288,
> - .fps = 60,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_CIF_30fps,
> - },
> - {
> - .width = 176,
> - .height = 144,
> - .fps = 60,
> - .pix_clk_freq = 66,
> - .pixels_per_line = 1698,//1704,
> - .lines_per_frame = 1294,
> - .skip_frames = 3,
> - .regs = ov2680_QCIF_30fps,
> - },
> -};
> -
> -#define N_RES_PREVIEW (ARRAY_SIZE(ov2680_res_preview))
> -
> #endif
> --
> 2.39.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-24 10:44 UTC|newest]
Thread overview: 168+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 12:51 [PATCH 00/57] media: atomisp: Big power-management changes + lots of fixes Hans de Goede
2023-01-23 12:51 ` [PATCH 01/57] media: atomisp: fix videobuf2 Kconfig depenendency Hans de Goede
2023-01-23 14:12 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 02/57] media: atomisp: use vb2_start_streaming_called() Hans de Goede
2023-01-23 12:51 ` [PATCH 03/57] media: atomisp: Remove atomisp_sw_contex struct Hans de Goede
2023-01-23 14:14 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 04/57] media: atomisp: Move power-management over to a custom pm-domain Hans de Goede
2023-01-23 12:51 ` [PATCH 05/57] media: atomisp: Silence "isys dma store at addr, val" debug messages Hans de Goede
2023-01-23 14:18 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 06/57] media: atomisp: Remove non working doorbell check from punit_ddr_dvfs_enable() Hans de Goede
2023-01-23 12:51 ` [PATCH 07/57] media: atomisp: Remove useless msleep(10) before power-on on BYT Hans de Goede
2023-01-23 14:40 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 08/57] media: atomisp: Remove custom ATOMISP_IOC_ISP_MAKERNOTE ioctl Hans de Goede
2023-01-23 14:30 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 09/57] media: atomisp: Remove custom ATOMISP_IOC_G_SENSOR_MODE_DATA ioctl Hans de Goede
2023-01-23 14:31 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 10/57] media: atomisp: Remove V4L2_CID_BIN_FACTOR_HORZ/_VERT Hans de Goede
2023-01-23 14:33 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 11/57] media: atomisp: Remove no longer used binning info from sensor resolution info Hans de Goede
2023-01-23 14:33 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 12/57] media: atomisp: Propagate set_fmt() errors in queue_setup() Hans de Goede
2023-01-23 14:35 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 13/57] media: atomisp: Remove deferred firmware loading support Hans de Goede
2023-01-23 14:37 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 14/57] media: atomisp: Check buffer index is in range inside atomisp_qbuf_wrapper() Hans de Goede
2023-01-23 14:38 ` Andy Shevchenko
2023-01-24 11:09 ` Hans de Goede
2023-01-23 12:51 ` [PATCH 15/57] media: atomisp: Drop atomisp_init_pipe() Hans de Goede
2023-01-23 15:30 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 16/57] media: atomisp: Remove unnecessary memset(foo, 0, sizeof(foo)) calls Hans de Goede
2023-01-23 17:41 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 17/57] media: atomisp: Only set default_run_mode on first open of a stream/asd Hans de Goede
2023-01-23 17:42 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 18/57] media: atomisp: Do not turn off sensor when the atomisp-sub-dev does not own it Hans de Goede
2023-01-23 12:51 ` [PATCH 19/57] media: atomisp: Allow sensor drivers without a s_power callback Hans de Goede
2023-01-23 17:49 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 20/57] media: atomisp: Fix regulator registers on BYT devices with CRC PMIC Hans de Goede
2023-01-23 17:51 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 21/57] media: atomisp: Remove atomisp_gmin_find_subdev() Hans de Goede
2023-01-23 17:53 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 22/57] media: atomisp: Add atomisp_register_sensor_no_gmin() helper Hans de Goede
2023-01-23 17:55 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 23/57] media: atomisp: Fix WARN() when the vb2 start_streaming callback fails Hans de Goede
2023-01-23 17:56 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 24/57] media: atomisp: Drop ffmt local var from atomisp_set_fmt() Hans de Goede
2023-01-23 12:51 ` [PATCH 25/57] media: atomisp: Stop overriding padding w/h to 12 on BYT Hans de Goede
2023-01-23 17:59 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 26/57] media: atomisp: Put sensor ACPI devices in D3 before disable ACPI power-resources Hans de Goede
2023-01-23 12:51 ` [PATCH 27/57] media: atomisp: Remove isp_subdev_link_setup() Hans de Goede
2023-01-23 18:02 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 28/57] media: Add ovxxxx_16bit_addr_reg_helpers.h Hans de Goede
2023-01-23 18:09 ` Andy Shevchenko
2023-01-24 11:21 ` Hans de Goede
2023-01-24 12:47 ` Andy Shevchenko
2023-01-23 18:15 ` Andy Shevchenko
2023-01-23 18:23 ` Andy Shevchenko
2023-01-24 11:25 ` Hans de Goede
2023-02-08 9:52 ` Laurent Pinchart
2023-02-08 11:27 ` Andy Shevchenko
2023-02-08 15:41 ` Laurent Pinchart
2023-02-08 15:50 ` Andy Shevchenko
2023-02-08 16:03 ` Laurent Pinchart
2023-02-08 17:31 ` Andy Shevchenko
2023-02-09 10:31 ` Laurent Pinchart
2023-02-09 15:03 ` Hans de Goede
2023-02-09 16:11 ` Laurent Pinchart
2023-02-10 10:21 ` Sakari Ailus
2023-02-10 10:29 ` Laurent Pinchart
2023-02-10 10:47 ` Sakari Ailus
2023-02-10 10:53 ` Andy Shevchenko
2023-02-10 11:05 ` Laurent Pinchart
2023-02-10 15:35 ` Andy Shevchenko
2023-02-10 16:01 ` Hans de Goede
2023-02-10 11:19 ` Hans de Goede
2023-02-10 11:35 ` Laurent Pinchart
2023-02-10 12:01 ` Hans de Goede
2023-02-10 11:04 ` Laurent Pinchart
2023-02-10 11:18 ` Sakari Ailus
2023-02-10 11:34 ` Laurent Pinchart
2023-02-10 11:20 ` Hans de Goede
2023-02-10 11:45 ` Laurent Pinchart
2023-02-10 11:56 ` Hans de Goede
2023-02-10 12:09 ` Laurent Pinchart
2023-02-10 12:17 ` Sakari Ailus
2023-02-10 12:59 ` Hans de Goede
2023-02-10 13:31 ` Sakari Ailus
2023-02-10 12:47 ` Hans de Goede
2023-02-10 13:18 ` Sakari Ailus
2023-02-10 14:43 ` Hans de Goede
2023-02-10 16:43 ` Laurent Pinchart
2023-02-10 20:16 ` Sakari Ailus
2023-02-10 12:26 ` Sakari Ailus
2023-02-10 15:42 ` Andy Shevchenko
2023-02-10 16:39 ` Laurent Pinchart
2023-02-10 20:18 ` Sakari Ailus
2023-02-10 16:40 ` Laurent Pinchart
2023-02-08 11:31 ` Sakari Ailus
2023-02-08 14:33 ` Mauro Carvalho Chehab
2023-02-08 15:39 ` Laurent Pinchart
2023-01-23 12:51 ` [PATCH 29/57] media: atomisp: ov2680: Use the new ovxxxx_16bit_addr_reg_helpers.h Hans de Goede
2023-01-23 18:13 ` Andy Shevchenko
2023-01-24 11:22 ` Hans de Goede
2023-01-23 12:51 ` [PATCH 30/57] media: atomisp: ov2680: Rework flip ctrls Hans de Goede
2023-01-23 18:33 ` Andy Shevchenko
2023-01-29 0:36 ` kernel test robot
2023-01-23 12:51 ` [PATCH 31/57] media: atomisp: ov2680: Drop custom ATOMISP_IOC_S_EXPOSURE support Hans de Goede
2023-01-23 18:35 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 32/57] media: atomisp: ov2680: Add exposure and gain controls Hans de Goede
2023-01-23 18:43 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 33/57] media: atomisp: ov2680: Add test pattern control Hans de Goede
2023-01-23 18:46 ` Andy Shevchenko
2023-01-24 11:27 ` Hans de Goede
2023-01-24 12:50 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 34/57] media: atomisp: ov2680: Fix window settings and enable window for all resolutions Hans de Goede
2023-01-23 18:48 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 35/57] media: atomisp: ov2680: Make setting the modes algorithm based Hans de Goede
2023-01-24 10:37 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 36/57] media: atomisp: ov2680: Use defines for fps, lines-per-frame and skip-frames Hans de Goede
2023-01-24 10:40 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 37/57] media: atomisp: ov2680: Drop unused res member from struct ov2680_device Hans de Goede
2023-01-24 10:39 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 38/57] media: atomisp: ov2680: Fix ov2680_enum_frame_interval() Hans de Goede
2023-01-24 10:42 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 39/57] media: atomisp: ov2680: Drop v4l2_find_nearest_size() call from set_fmt() Hans de Goede
2023-01-24 10:43 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 40/57] media: atomisp: ov2680: Drop struct ov2680_resolution / ov2680_res_preview Hans de Goede
2023-01-24 10:44 ` Andy Shevchenko [this message]
2023-01-23 12:51 ` [PATCH 41/57] media: atomisp: ov2680: Fix frame_size list Hans de Goede
2023-01-24 10:46 ` Andy Shevchenko
2023-01-24 11:29 ` Hans de Goede
2023-01-23 12:51 ` [PATCH 42/57] media: atomisp: ov2680: Remove unused data-types and defines from ov2680.h Hans de Goede
2023-01-24 10:46 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 43/57] media: atomisp: ov2680: Drop MAX_FMTS define Hans de Goede
2023-01-24 10:48 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 44/57] media: atomisp: ov2680: Consistently indent define values Hans de Goede
2023-01-24 10:49 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 45/57] media: atomisp: ov2680: Cleanup includes Hans de Goede
2023-01-24 10:50 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 46/57] media: atomisp: ov2680: Delay power-on till streaming is started Hans de Goede
2023-01-24 10:51 ` Andy Shevchenko
2023-01-24 11:31 ` Hans de Goede
2023-01-24 12:52 ` Andy Shevchenko
2023-01-24 13:35 ` Hans de Goede
2023-01-23 12:51 ` [PATCH 47/57] media: atomisp: ov2680: Add runtime-pm support Hans de Goede
2023-01-24 10:53 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 48/57] media: atomisp: ov2680: s/dev/sensor/ Hans de Goede
2023-01-24 10:54 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 49/57] media: atomisp: ov2680: Use devm_kzalloc() for sensor data struct Hans de Goede
2023-01-24 10:55 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 50/57] media: atomisp: ov2680: Switch over to ACPI powermanagement Hans de Goede
2023-01-24 10:59 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 51/57] media: atomisp: ov2722: Call atomisp_gmin_remove_subdev() on probe failure Hans de Goede
2023-01-23 18:36 ` Andy Shevchenko
2023-01-23 12:52 ` [PATCH 52/57] media: atomisp: ov2722: Fix GPIO1 polarity Hans de Goede
2023-01-23 18:39 ` Andy Shevchenko
2023-01-23 18:40 ` Andy Shevchenko
2023-01-23 12:52 ` [PATCH 53/57] media: atomisp: ov2722: Don't take the input_lock for try_fmt calls Hans de Goede
2023-01-23 18:39 ` Andy Shevchenko
2023-01-23 12:52 ` [PATCH 54/57] media: atomisp: ov2722: Power on sensor from set_fmt() callback Hans de Goede
2023-01-23 18:42 ` Andy Shevchenko
2023-01-24 11:32 ` Hans de Goede
2023-01-23 12:52 ` [PATCH 55/57] media: atomisp: pci: Replace bytes macros with functions Hans de Goede
2023-01-23 12:52 ` [PATCH 56/57] media: atomisp: pci: hive_isp_css_common: host: vmem: Replace SUBWORD " Hans de Goede
2023-01-23 18:27 ` Andy Shevchenko
2023-01-23 18:29 ` Andy Shevchenko
2023-01-23 12:52 ` [PATCH 57/57] media: atomisp: pci: sh_css: Inline single invocation of macro STATS_ENABLED() Hans de Goede
2023-01-24 11:01 ` [PATCH 00/57] media: atomisp: Big power-management changes + lots of fixes Andy Shevchenko
2023-01-24 11:05 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8+2pOGesbxkvWOC@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=andrey.i.trufanov@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nable.maininbox@googlemail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=yury.lunev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).