From: Dan Carpenter <error27@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Diederik de Haas <didi.debian@cknow.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: Fix full name of the GPL
Date: Mon, 23 Jan 2023 15:04:48 +0300 [thread overview]
Message-ID: <Y8534H/2JvussfAh@kadam> (raw)
In-Reply-To: <Y85Kkax5+U4AUedT@debian.me>
On Mon, Jan 23, 2023 at 03:51:29PM +0700, Bagas Sanjaya wrote:
> On Mon, Jan 23, 2023 at 08:00:35AM +0100, Greg Kroah-Hartman wrote:
> > - You did not specify a description of why the patch is needed, or
> > possibly, any description at all, in the email body. Please read the
> > section entitled "The canonical patch format" in the kernel file,
> > Documentation/process/submitting-patches.rst for what is needed in
> > order to properly describe the change.
> >
>
> Hi Greg,
>
> drivers/staging/wlan-ng/hfa384x.h (for example) has already SPDX identifier
> that matches the verbose copyright notice below it.
Resend the patch with a better commit message.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
next prev parent reply other threads:[~2023-01-23 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 19:10 [PATCH] staging: wlan-ng: Fix full name of the GPL Diederik de Haas
2023-01-23 7:00 ` Greg Kroah-Hartman
2023-01-23 8:51 ` Bagas Sanjaya
2023-01-23 9:35 ` Greg Kroah-Hartman
2023-01-23 13:54 ` Bagas Sanjaya
2023-01-23 12:04 ` Dan Carpenter [this message]
2023-01-23 12:53 ` Diederik de Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8534H/2JvussfAh@kadam \
--to=error27@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=didi.debian@cknow.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).