From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBC38EA5 for ; Mon, 23 Jan 2023 14:40:07 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="353316808" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="353316808" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 06:40:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="639172461" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="639172461" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP; 23 Jan 2023 06:40:04 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pJxzO-00Dmbt-0B; Mon, 23 Jan 2023 16:40:02 +0200 Date: Mon, 23 Jan 2023 16:40:01 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Mauro Carvalho Chehab , Sakari Ailus , Tsuchiya Yuto , Yury Luneff , Nable , andrey.i.trufanov@gmail.com, Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 07/57] media: atomisp: Remove useless msleep(10) before power-on on BYT Message-ID: References: <20230123125205.622152-1-hdegoede@redhat.com> <20230123125205.622152-8-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123125205.622152-8-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Jan 23, 2023 at 01:51:15PM +0100, Hans de Goede wrote: > On BYT on poweron/runtime-resume the code is doing: > > 1. Do nothing > 2. msleep(10) > 3. Start actual poweron sequence > > Since the runtime resume can happen at any moment, waiting 10ms > after it does not really make any sense. > > According to both the comment and to: > https://github.com/intel/ProductionKernelQuilts/blob/master/uefi/cht-m1stable/patches/cam-0341-atomisp-WA-sleep-10ms-when-power-up-ISP-on-byt.patch > > Which is the patch which originally added this this was added > as a workaround for a single test failing on a single model > tablet/laptop. So lets just drop this. Since it's for BYT platforms and you have plenty to test, I believe it's the right thing to do. Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > index 9eea8ffbc3d6..aa05c69a5c6b 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > @@ -665,14 +665,6 @@ static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) > msleep(20); > } > > - /* > - * FIXME:WA for ECS28A, with this sleep, CTS > - * android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceAbort > - * PASS, no impact on other platforms > - */ > - if (IS_BYT && enable) > - msleep(10); > - > /* Write to ISPSSPM0 bit[1:0] to power on/off the IUNIT */ > iosf_mbi_modify(BT_MBI_UNIT_PMC, MBI_REG_READ, MRFLD_ISPSSPM0, > val, MRFLD_ISPSSPM0_ISPSSC_MASK); > -- > 2.39.0 > -- With Best Regards, Andy Shevchenko