From: Andy Shevchenko <andy@kernel.org>
To: Brent Pappas <bpappas@pappasbrent.com>
Cc: hdegoede@redhat.com, mchehab@kernel.org, ailus@linux.intel.com,
gregkh@linuxfoundation.org, error27@gmail.com,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: pci: Replace bytes macros with functions
Date: Tue, 17 Jan 2023 17:35:32 +0200 [thread overview]
Message-ID: <Y8bARLuFubMVILIN@smile.fi.intel.com> (raw)
In-Reply-To: <Y8a/9GI+OsSRo+te@smile.fi.intel.com>
On Tue, Jan 17, 2023 at 05:34:12PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 17, 2023 at 10:08:41AM -0500, Brent Pappas wrote:
> > Replace the function-like macros FPNTBL_BYTES, SCTBL_BYTES, and
> > MORPH_PLANE_BYTES with static inline functions to comply with Linux coding
> > style standards.
>
> Thank you!
>
> But I think what you need, besides dropping unneeded parentheses, is to use some
> macros from overflow.h.
And drop "staging:" prefix from the patch since media maintainer uses (dumb)
script that adds "media:" if it doesn't lead the Subject.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-17 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 15:08 [PATCH] staging: media: atomisp: pci: Replace bytes macros with functions Brent Pappas
2023-01-17 15:34 ` Andy Shevchenko
2023-01-17 15:35 ` Andy Shevchenko [this message]
2023-01-17 16:16 ` [PATCH v2] " Brent Pappas
2023-01-17 18:08 ` Andy Shevchenko
2023-01-17 18:31 ` [PATCH v3] " Brent Pappas
2023-01-17 18:37 ` Andy Shevchenko
2023-01-18 14:42 ` [PATCH v4] " Brent Pappas
2023-01-18 14:56 ` Dan Carpenter
2023-01-18 15:16 ` [PATCH v5] " Brent Pappas
2023-01-18 15:26 ` Dan Carpenter
2023-01-18 15:53 ` Andy Shevchenko
2023-01-18 16:07 ` [PATCH v6] " Brent Pappas
2023-01-18 16:17 ` Andy Shevchenko
2023-01-18 17:41 ` Brent Pappas
2023-01-23 12:27 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8bARLuFubMVILIN@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=ailus@linux.intel.com \
--cc=bpappas@pappasbrent.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).