From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDF85257E for ; Thu, 19 Jan 2023 14:32:29 +0000 (UTC) Received: by mail-wm1-f43.google.com with SMTP id iv8-20020a05600c548800b003db04a0a46bso3111457wmb.0 for ; Thu, 19 Jan 2023 06:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wS7HSylCm9otocOdYBhDnMFqnI4PKH4nfYFHOFNvW3g=; b=ZyeibTCU3dHPBSQm3WEHymYSJKlzsLGwKkfHxwUW+zHH042eB7+IP/Sj0sEQFz6Jcj qu4v3JFderI0jEofEgqUdNuzs2JAeJgMZqswIkfxy32njBcZthC3qWipijH92mL4KqFr +8sdV/pFoM6gcD4xk1Ql6rKYxJr19dAPyeJDJYd/yqx93L/crHwkdHENThnjCJptZ4u+ uk5ORYgoPKm7KD0QUqFC276bwEUOnYm7ap9lWdW3bEFX77L55hRkf02Z68of/uzFMdal eoUdH52gXk0xreepJohtwXGYXwkv5zX4/k7+HKFW6/RuO7awltBN5yy01HaDHG4Iv5Sw 79jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wS7HSylCm9otocOdYBhDnMFqnI4PKH4nfYFHOFNvW3g=; b=OIvL4mmAWY5h+CVUkilt7fQtCpuQ0u/eRd0HTKTjTt4Jg4MSSL8IiPzw9JZpwju8f8 98jA/dAmmQ8G3jjl1XoOu8HOfQ4q57v45PD6speVXBLEm58DxMS6ZN17gsZh2Qpb4atX qu/D5CpCkb83OdQ3P8fZ6/ZZ7ttLGhIGBVXR51t4VRVtpcWqAAgYJAMZBI2pvAv6l/cZ UwrC2npy62p/DmTVka+niekVLfxTOktQ859Ayk7MPDp5v+KNTcc7mlX54AYeQGdMLV8c wNHUez7dqMB1dCvPh4rQtZ/iM1WkI/H46voMpZeLG45tdMGI6IaBLhmsUgPmLPLmRVQU lJug== X-Gm-Message-State: AFqh2koD3iF0eYJJS7LaMy1Y7mCDrhB2SYHauw+AoBnh5fK0O+e41hBj EFi5foR+xpj1JchbVKDuA5s= X-Google-Smtp-Source: AMrXdXsk3J0ufP1mfd0P9SekZ3FFkzaf0xCJj0h4j/1DCaEarvPaz9ltTd8g8lO+rl2wWrcKN7nq4A== X-Received: by 2002:a05:600c:1e19:b0:3da:2ba4:b97 with SMTP id ay25-20020a05600c1e1900b003da2ba40b97mr17848869wmb.19.1674138748164; Thu, 19 Jan 2023 06:32:28 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id z4-20020a1cf404000000b003da2932bde0sm5701400wma.23.2023.01.19.06.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 06:32:27 -0800 (PST) Date: Thu, 19 Jan 2023 17:32:24 +0300 From: Dan Carpenter To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dave Stevenson , Kieran Bingham , Laurent Pinchart Subject: Re: [RFC PATCH 1/4] staging: vc04_services: vchiq_core: Drop custom logging Message-ID: References: <20230118115810.21979-1-umang.jain@ideasonboard.com> <20230118115810.21979-2-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230118115810.21979-2-umang.jain@ideasonboard.com> On Wed, Jan 18, 2023 at 05:28:07PM +0530, Umang Jain wrote: > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > index 4e705a447a62..7b3c57326d28 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > @@ -227,10 +227,11 @@ static const char *msg_type_str(unsigned int msg_type) > static inline void > set_service_state(struct vchiq_service *service, int newstate) > { > - vchiq_log_info(vchiq_core_log_level, "%d: srv:%d %s->%s", > - service->state->id, service->localport, > - srvstate_names[service->srvstate], > - srvstate_names[newstate]); > + struct vchiq_state *state = service->state; > + > + dev_info(state->dev, "%d: srv:%d %s->%s", state->id, > + service->localport, srvstate_names[service->srvstate], > + srvstate_names[newstate]); This should be a debug level printk. Don't spam dmesg in the success path. Success should not be noteworthy. > service->srvstate = newstate; > } regards, dan carpenter