From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: vt6655: Macro with braces issue change to inline function
Date: Sun, 5 Feb 2023 14:16:07 +0100 [thread overview]
Message-ID: <Y9+sFw0rviTAJNMf@kroah.com> (raw)
In-Reply-To: <Y9+qMqYD2zGWRurD@combine-ThinkPad-S1-Yoga>
On Sun, Feb 05, 2023 at 02:08:02PM +0100, Guru Mehar Rachaputi wrote:
> This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
> as '(iobase)' to avoid precedence issues"
>
> ---
> Changes in v3:
> - Whitespace error from checkpatch fixed
>
> Changes in v2:
> - Macros with one statement that is to call 'iowrite8' function changed
> to inline function as reviewed by gregkh@linuxfoundation.org.
> In relation to this, names of the callers of macro are also modified
> to call this function.
>
> Signed-off-by: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
Try to take this patch and apply it to a tree, and see that everything
below the --- line is thrown away, including your signed-off-by: line :(
next prev parent reply other threads:[~2023-02-05 13:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 13:08 [PATCH v3] staging: vt6655: Macro with braces issue change to inline function Guru Mehar Rachaputi
2023-02-05 13:16 ` Greg Kroah-Hartman [this message]
2023-02-05 13:30 ` Guru Mehar Rachaputi
2023-02-05 15:34 ` Nam Cao
2023-02-05 18:13 ` Guru Mehar Rachaputi
2023-02-05 18:21 ` Guru Mehar Rachaputi
2023-02-05 13:16 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2023-02-05 18:11 Guru Mehar Rachaputi
2023-02-05 19:12 ` Christophe JAILLET
2023-02-05 23:39 ` Guru Mehar Rachaputi
2023-02-06 9:43 ` Greg Kroah-Hartman
2023-02-07 7:25 ` Guru Mehar Rachaputi
2023-02-07 7:39 ` Greg Kroah-Hartman
2023-02-07 8:52 ` Guru Mehar Rachaputi
[not found] ` <Y+IJgxF52lpgk0RC@ubun2204.myguest.virtualbox.org>
2023-02-07 8:49 ` Guru Mehar Rachaputi
2023-02-07 9:47 ` Deepak R Varma
2023-03-06 4:52 ` Guru Mehar Rachaputi
2023-03-06 5:36 ` Deepak R Varma
2023-03-06 5:57 ` Guru Mehar Rachaputi
2023-03-06 7:00 ` Deepak R Varma
2023-03-06 7:48 ` Guru Mehar Rachaputi
[not found] ` <ZAWkzuCF9GaqnnaJ@ubun2204.myguest.virtualbox.org>
2023-03-08 17:23 ` Guru Mehar Rachaputi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9+sFw0rviTAJNMf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=gurumeharrachaputi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox