From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>,
Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: Regarding checkpatch camelcase issues
Date: Sat, 4 Feb 2023 14:40:41 +0700 [thread overview]
Message-ID: <Y94L+WNGGfvrg6Mg@debian.me> (raw)
In-Reply-To: <Y93eQqaYdL146Z65@combine-ThinkPad-S1-Yoga>
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
On Sat, Feb 04, 2023 at 05:25:38AM +0100, Guru Mehar Rachaputi wrote:
> Thanks for your support.
>
> I wanted to confirm if each checkpatch encounter for camelcase issue should
> be fixed in a new patch?
>
> For example: If the issue is with same variable, then multiple
> modifications can be made in one patch.
>
> -> above example is OK
>
>
> For example: If the issue is with multiple variables, then multiple
> modifications can be made in one patch.
>
> -> above example is NOT OK / NG
>
>
> Please confirm me if my understanding is correct?
>
I guess you have generated a patch series, then check it through
checkpatch.
Indeed, if checkpatch complains at a particular patch, you need to do
interactive rebase. Make sure that rebase todo list contains "edit"
lines on commit you want to fix up. After that, fix these complaints.
When you're done, regenerate the patch series and make sure that there
are no checkpatch complains on it.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-02-04 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 4:25 Regarding checkpatch camelcase issues Guru Mehar Rachaputi
2023-02-04 7:40 ` Bagas Sanjaya [this message]
2023-02-04 23:46 ` Guru Mehar Rachaputi
[not found] ` <Y98wHhGMY1eSaWG1@ubun2204.myguest.virtualbox.org>
2023-02-05 13:13 ` Guru Mehar Rachaputi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y94L+WNGGfvrg6Mg@debian.me \
--to=bagasdotme@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=gurumeharrachaputi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox