From: Dan Carpenter <error27@gmail.com>
To: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: modify bit_rate from u16 to u32
Date: Tue, 31 Jan 2023 14:14:12 +0300 [thread overview]
Message-ID: <Y9j4BI3/ybsaLCfw@kadam> (raw)
In-Reply-To: <Y9jy+f5JpD1NrbZn@combine-ThinkPad-S1-Yoga>
On Tue, Jan 31, 2023 at 11:52:41AM +0100, Guru Mehar Rachaputi wrote:
> I would like to know, if it is mentioned in the TODO, why is it
> so?
>
If it were as simple as just changing the type, they would have done
that instead of adding it to the TODO. :P
But in fairness the TODO entry is sort of vague and useless. It should
say that this configuration stuff needs to be moved to sysfs instead of
being done through an IOCTL. The we would need to port the userspace
tools to use sysfs instead of the IOCTL. Then we would delete the
IOCTL.
https://lore.kernel.org/all/20220118135902.GH1951@kadam/
If you want to send a patch to update the TODO then you can do that.
regards,
dan carpenter
next prev parent reply other threads:[~2023-01-31 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 2:11 [PATCH] staging: pi433: modify bit_rate from u16 to u32 Guru Mehar Rachaputi
2023-01-31 5:22 ` Greg Kroah-Hartman
2023-01-31 10:19 ` Guru Mehar Rachaputi
2023-01-31 10:41 ` Greg Kroah-Hartman
2023-01-31 10:52 ` Guru Mehar Rachaputi
2023-01-31 11:14 ` Dan Carpenter [this message]
2023-01-31 18:18 ` Guru Mehar Rachaputi
2023-02-01 12:34 ` David Laight
2023-02-01 13:22 ` Dan Carpenter
2023-02-02 22:02 ` David Laight
2023-02-02 22:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9j4BI3/ybsaLCfw@kadam \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gurumeharrachaputi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox