From: Greg KH <gregkh@linuxfoundation.org>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: dan.carpenter@oracle.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)
Date: Fri, 26 Mar 2021 17:20:40 +0100 [thread overview]
Message-ID: <YF4J2JVz1tHiFsGJ@kroah.com> (raw)
In-Reply-To: <20210326155252.6746-1-fabioaiuto83@gmail.com>
On Fri, Mar 26, 2021 at 04:52:52PM +0100, Fabio Aiuto wrote:
> fix indentation broken by patch removing conditional
> code blocks checked by unused
> CONFIG_INTERRUPT_BASED_TXBCN family defines
>
> https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com
No, please use a "Fixes:" tag that points to the git commit id that this
commit fixes. Look in the kernel tree for loads of examples of how to
do this, and it's even documented in the Documentation/ process guide as
well.
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-26 16:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 8:56 [bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN* Dan Carpenter
2021-03-25 9:56 ` [PATCH] staging: rtl8723bs: fix indentation broken by previous patch Fabio Aiuto
2021-03-26 8:24 ` [bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN* Fabio Aiuto
2021-03-26 11:03 ` Dan Carpenter
2021-03-26 9:17 ` [PATCH] staging: rtl8723bs: fix indentation broken by previous patch Fabio Aiuto
2021-03-26 14:06 ` Greg KH
2021-03-26 15:52 ` [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) Fabio Aiuto
2021-03-26 16:20 ` Greg KH [this message]
2021-03-26 17:43 ` Fabio Aiuto
2021-03-26 17:57 ` Fabio Aiuto
2021-03-26 18:06 ` [PATCH] staging: rtl8723bs: fix broken indentation Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF4J2JVz1tHiFsGJ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox