From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BFF06D0E for ; Wed, 7 Apr 2021 07:24:10 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 711D761369; Wed, 7 Apr 2021 07:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617780250; bh=c8QTi+AIP6Z54tg+BWl56LNU1Ps+kKiQ9QeE1c64AQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K68BONJW/E2R6IZwwl554zQwgj3s+DXec55UZYBqa2SXacCDOQruQlxyydYqn65cN B5X3MHl8eHLUDrfP6XSpbLUC1o8779ITZb3/izkQxHngClEdT8xiBwxSyj+mkmT3s1 gG4wh3mq23YM+XgeipmOLUb7x/ndJmlmX8vOFwCk= Date: Wed, 7 Apr 2021 09:24:07 +0200 From: Greg KH To: Pavle Rohalj Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/49] staging: sm750fb: Update enum values in dpms to snake case Message-ID: References: <16693e7cc62f84ea1ec34b7d5cbd77c4cd1965e8.1617776878.git.pavle.rohalj@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16693e7cc62f84ea1ec34b7d5cbd77c4cd1965e8.1617776878.git.pavle.rohalj@gmail.com> On Tue, Apr 06, 2021 at 11:36:16PM -0700, Pavle Rohalj wrote: > Fix "Avoid CamelCase" checkpatch.pl checks for values in > enum dpms. > > Signed-off-by: Pavle Rohalj > --- > drivers/staging/sm750fb/ddk750_power.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h > index 7002567a47d2..4756db1ccb9c 100644 > --- a/drivers/staging/sm750fb/ddk750_power.h > +++ b/drivers/staging/sm750fb/ddk750_power.h > @@ -3,10 +3,10 @@ > #define DDK750_POWER_H__ > > enum dpms { > - crtDPMS_ON = 0x0, > - crtDPMS_STANDBY = 0x1, > - crtDPMS_SUSPEND = 0x2, > - crtDPMS_OFF = 0x3, > + CRT_DPMS_ON = 0x0, > + CRT_DPMS_STANDBY = 0x1, > + CRT_DPMS_SUSPEND = 0x2, > + CRT_DPMS_OFF = 0x3, > }; And the build does not break with this change? If so, then why are these here at all? thanks, greg k-h