From: Greg KH <gregkh@linuxfoundation.org>
To: Barney Goette <barneygoette@gmail.com>
Cc: arve@android.com, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] Staging: android: ashmem: Fixed a const coding style issue
Date: Wed, 7 Apr 2021 16:48:13 +0200 [thread overview]
Message-ID: <YG3GLQA1O3b0w0RY@kroah.com> (raw)
In-Reply-To: <20210407143502.3414-1-barneygoette@gmail.com>
On Wed, Apr 07, 2021 at 09:35:02AM -0500, Barney Goette wrote:
> Fixed a coding style issue.
> Reported by checkpatch.
>
> Signed-off-by: Barney Goette <barneygoette@gmail.com>
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index d66a64e42273..7854fd410efa 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
> struct ashmem_area *asma = file->private_data;
> int ret = 0;
>
> --
> 2.25.1
Why did you not test-build your patch before sending it out?
Always do so.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-07 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 14:35 [PATCH] Staging: android: ashmem: Fixed a const coding style issue Barney Goette
2021-04-07 14:48 ` Greg KH [this message]
[not found] ` <606dcaee.1c69fb81.df22.7ca0@mx.google.com>
2021-04-07 15:15 ` [PATCH] Staging: android: ashmem: Fixed a const coding styleissue Greg KH
2021-04-07 23:56 ` [PATCH] Staging: android: ashmem: Fixed a const coding style issue kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG3GLQA1O3b0w0RY@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=barneygoette@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox