From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E375A6D0E for ; Wed, 7 Apr 2021 14:48:16 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E09CA61260; Wed, 7 Apr 2021 14:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617806896; bh=s4YHVX6I4KFaEOaDuE91HtM/xl0oR/OIQH9ovTk2uTw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J47mtbpE/V6HL4mHsYSe3PvbrSQzJG+3zVxK30e8SQmcjs9R+3SrbnPtMMYsuk/pb i8oJcirGFKFeA9ouXJMX6YZKqesYThRHIwWv2AlxWWmq76mU2jpVOrx/W/VdM7boMK M8XTFhMNqw5wOonW3co4XkYKEzTVo0/ABVf7vDOU= Date: Wed, 7 Apr 2021 16:48:13 +0200 From: Greg KH To: Barney Goette Cc: arve@android.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] Staging: android: ashmem: Fixed a const coding style issue Message-ID: References: <20210407143502.3414-1-barneygoette@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407143502.3414-1-barneygoette@gmail.com> On Wed, Apr 07, 2021 at 09:35:02AM -0500, Barney Goette wrote: > Fixed a coding style issue. > Reported by checkpatch. > > Signed-off-by: Barney Goette > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index d66a64e42273..7854fd410efa 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > > -- > 2.25.1 Why did you not test-build your patch before sending it out? Always do so. thanks, greg k-h