From: Greg KH <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files
Date: Thu, 8 Apr 2021 10:36:32 +0200 [thread overview]
Message-ID: <YG7AkJjSThRbb/f5@kroah.com> (raw)
In-Reply-To: <20210408080714.29481-1-fmdefrancesco@gmail.com>
On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote:
> Remove camelcase in a symbol that is used by several files.
What symbol?
> --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
> @@ -203,7 +203,7 @@ struct pwrctrl_priv {
> u8 LpsIdleCount;
> u8 power_mgnt;
> u8 org_power_mgnt;
> - u8 bFwCurrentInPSMode;
> + u8 b_fw_current_in_ps_mode;
The "b" here means "byte" so you can drop the "b_" as that means
nothing, we do not use this type of notation in the kernel as the
compiler can check it for us.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-08 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 8:07 [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files Fabio M. De Francesco
2021-04-08 8:36 ` Greg KH [this message]
2021-04-08 8:52 ` Fabio M. De Francesco
2021-04-08 8:54 ` Julia Lawall
2021-04-08 9:10 ` Fabio M. De Francesco
2021-04-08 8:53 ` Julia Lawall
2021-04-08 9:23 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG7AkJjSThRbb/f5@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox