From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A9CC6F for ; Wed, 31 Mar 2021 10:27:55 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4905561990; Wed, 31 Mar 2021 10:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617186475; bh=POFYW6ppDl60/r0ymeE58Xy5GnEKMtFjnA12DkmNL8Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=svM+D3ItRTMZDPtZxLQMP+I8VJL2SsL2vaqprNxSyY/g6Z8jIzzExydBlrxjdWxyU 9c9H69TbJUIjHapcw+5QFb6pGMJ1WPKMYwyfeZozGFijnfdSCkkCm9qmHbIXxDzDFs F+S2k+hTNuEdVnjLkV1Rt+yacBvp9OvcDlBIO+s0= Date: Wed, 31 Mar 2021 12:27:51 +0200 From: Greg KH To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH -next] staging: rtl8723bs: os_dep: remove unused variable 'ret' Message-ID: References: <20210331094247.2169606-1-yangyingliang@huawei.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210331094247.2169606-1-yangyingliang@huawei.com> On Wed, Mar 31, 2021 at 05:42:47PM +0800, Yang Yingliang wrote: > GCC reports the following warning with W=1: > > drivers/staging/rtl8723bs/os_dep/recv_linux.c:101:6: warning: > variable ‘ret’ set but not used [-Wunused-but-set-variable] > 101 | int ret; > | ^~~ > > This variable is not used in function , this commit > remove it to fix the warning. > > Fixes: de69e2b3f105 ("staging: rtl8723bs: remove DBG_COUNTER calls from os_dep/recv_linux.c") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/staging/rtl8723bs/os_dep/recv_linux.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c > index fbdbcd04d44a..f6a9482be8e3 100644 > --- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c > +++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c > @@ -98,7 +98,6 @@ struct sk_buff *rtw_os_alloc_msdu_pkt(union recv_frame *prframe, u16 nSubframe_L > void rtw_os_recv_indicate_pkt(struct adapter *padapter, struct sk_buff *pkt, struct rx_pkt_attrib *pattrib) > { > struct mlme_priv *pmlmepriv = &padapter->mlmepriv; > - int ret; > > /* Indicate the packets to upper layer */ > if (pkt) { > @@ -140,7 +139,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, struct sk_buff *pkt, str > > pkt->ip_summed = CHECKSUM_NONE; > > - ret = rtw_netif_rx(padapter->pnetdev, pkt); > + rtw_netif_rx(padapter->pnetdev, pkt); Why not handle the result of this call properly?