From: Greg KH <gregkh@linuxfoundation.org>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: dan.carpenter@oracle.com, joe@perches.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c
Date: Sat, 3 Apr 2021 09:40:08 +0200 [thread overview]
Message-ID: <YGgb2Mtzyp79elQ6@kroah.com> (raw)
In-Reply-To: <34b6f0b80cd3913722b258e9554dbc77268fb2bf.1617384172.git.fabioaiuto83@gmail.com>
On Fri, Apr 02, 2021 at 07:29:43PM +0200, Fabio Aiuto wrote:
> remove all RT_TRACE logs
>
I don't mean to be a pain, but this changelog text needs some work.
This says _what_ it does, but not _why_ you are doing this. The kernel
documentation has a section on how to write a good changelog text, you
might want to look at that.
For this type of series, this could be as simple as:
Remove all of the RT_TRACE_LOGs in the rtx_xmit.c file as they
currently do nothing as they require the code to be modified by
hand in order to be turned on. This obviously has not happened
since the code was merged, so just remove them as they are
unused.
Or something like that.
Most of the time, writing the changelog can take more work than the
actual code change itself, but it's important as we need to know what is
happening both for the reviewers, as well as people in the future who
might have to look back and try to understand the reason for specific
changes.
Can you fix up this series based on this and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-03 7:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 17:29 [PATCH v2 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/* Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c Fabio Aiuto
2021-04-03 7:40 ` Greg KH [this message]
2021-04-03 7:48 ` Fabio Aiuto
2021-04-03 7:50 ` Greg KH
2021-04-02 17:29 ` [PATCH v2 02/30] staging: rtl8723bs: fix condition in if statement Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 03/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 04/30] staging: rtl8723bs: fix line exceed warning Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 05/30] staging: rtl8723bs: fix spaces around operator issues Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 06/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 07/30] staging: rtl8723bs: fix error prone if conditions Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 08/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 09/30] staging: rtl8723bs: fix logical continuation issue Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 10/30] staging: rtl8723bs: remove unnecessary parentheses in if-condition Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 11/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 12/30] staging: rtl8723bs: fix null check conditions Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 13/30] staging: rtl8723bs: remove unnecessary parentheses in if condition Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 14/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 15/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 16/30] staging: rtl8723bs: tidy up some error handling Fabio Aiuto
2021-04-02 17:29 ` [PATCH v2 17/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 18/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 19/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 20/30] staging: rtl8723bs: added spaces around operator Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 21/30] staging: rtl8723bs: split long line Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 22/30] staging: rtl8723bs: remove unnecessary parentheses Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 23/30] staging: rtl8723bs: fix comparison in if condition Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 24/30] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 25/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 26/30] staging: rtl8723bs: place constant on the right side of the test Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 27/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 28/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 29/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c Fabio Aiuto
2021-04-02 17:30 ` [PATCH v2 30/30] staging: rtl8723bs: add spaces around operators Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGgb2Mtzyp79elQ6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox