From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23168259E for ; Sun, 4 Apr 2021 09:56:44 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C0F4661380; Sun, 4 Apr 2021 09:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617530203; bh=73hP+jEaoOThuXHQz9FoAHAQEROgVEtTny858He9dRY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nB1qT3VpR+ESVGTlYaK/nDen1ypyZifEgww/pPz7bOL6BN93VuEWJ2b71vUp96J6R nO6v6wkgyogp/tgjJhRKJqCUj6FNUL40O3Qz0IBoJtnKcHvGEa21HR0MKgM+GEz7Wt /hl36ExET76WwZokZnGpsMhLJfaaSjD0NEADjj4w= Date: Sun, 4 Apr 2021 11:56:40 +0200 From: Greg Kroah-Hartman To: Ivan Safonov Cc: Larry Finger , Michael Straube , "Gustavo A. R. Silva" , Peilin Ye , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging:r8188eu: remove dummy handlers from OnAction() Message-ID: References: <20210328163323.53163-1-insafonov@gmail.com> <20210328163323.53163-2-insafonov@gmail.com> <8955077a-94b6-9ffb-d2f6-b611845b6cfc@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8955077a-94b6-9ffb-d2f6-b611845b6cfc@gmail.com> On Sun, Apr 04, 2021 at 12:30:41AM +0300, Ivan Safonov wrote: > On 4/2/21 4:04 PM, Greg Kroah-Hartman wrote: > > On Sun, Mar 28, 2021 at 07:33:25PM +0300, Ivan Safonov wrote: > > > on_action_spct() do nothing, because rtw_get_stainfo() has no side > > > effects. Other action handlers are trivial. > > > > > > Signed-off-by: Ivan Safonov > > > > Same here, wrong driver name :( > > > > Driver name is "r8188eu"... > > $ grep 'r8188eu' drivers/staging/rtl8188eu/include/drv_types.h Directory name is "rtl8188eu", so something needs to be fixed up here to remove confusion like this :) thanks, greg k-h