From: Greg KH <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operators
Date: Tue, 6 Apr 2021 16:12:05 +0200 [thread overview]
Message-ID: <YGxsNVs+sexiPMJS@kroah.com> (raw)
In-Reply-To: <20210406130138.30744-1-fmdefrancesco@gmail.com>
On Tue, Apr 06, 2021 at 03:01:38PM +0200, Fabio M. De Francesco wrote:
> Added spaces around operators in file HalBtc8723b1Ant.c. Issue detected
> by checkpatch.pl. Spaces are preferred to improve readibility.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 98 +++++++++----------
> 1 file changed, 49 insertions(+), 49 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> index 3e794093092b..b2b872016e45 100644
> --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> @@ -38,7 +38,7 @@ static u8 halbtc8723b1ant_BtRssiState(
> (pCoexSta->preBtRssiState == BTC_RSSI_STATE_LOW) ||
> (pCoexSta->preBtRssiState == BTC_RSSI_STATE_STAY_LOW)
> ) {
> - if (btRssi >= (rssiThresh+BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> + if (btRssi >= (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
>
> btRssiState = BTC_RSSI_STATE_HIGH;
> BTC_PRINT(
> @@ -85,7 +85,7 @@ static u8 halbtc8723b1ant_BtRssiState(
> (pCoexSta->preBtRssiState == BTC_RSSI_STATE_LOW) ||
> (pCoexSta->preBtRssiState == BTC_RSSI_STATE_STAY_LOW)
> ) {
> - if (btRssi >= (rssiThresh+BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> + if (btRssi >= (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> btRssiState = BTC_RSSI_STATE_MEDIUM;
> BTC_PRINT(
> BTC_MSG_ALGORITHM,
> @@ -104,7 +104,7 @@ static u8 halbtc8723b1ant_BtRssiState(
> (pCoexSta->preBtRssiState == BTC_RSSI_STATE_MEDIUM) ||
> (pCoexSta->preBtRssiState == BTC_RSSI_STATE_STAY_MEDIUM)
> ) {
> - if (btRssi >= (rssiThresh1+BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> + if (btRssi >= (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> btRssiState = BTC_RSSI_STATE_HIGH;
> BTC_PRINT(
> BTC_MSG_ALGORITHM,
> @@ -353,11 +353,11 @@ static void halbtc8723b1ant_MonitorBtCtr(struct btc_coexist *pBtCoexist)
>
> u4Tmp = pBtCoexist->fBtcRead4Byte(pBtCoexist, regHPTxRx);
> regHPTx = u4Tmp & bMaskLWord;
> - regHPRx = (u4Tmp & bMaskHWord)>>16;
> + regHPRx = (u4Tmp & bMaskHWord) >> 16;
>
> u4Tmp = pBtCoexist->fBtcRead4Byte(pBtCoexist, regLPTxRx);
> regLPTx = u4Tmp & bMaskLWord;
> - regLPRx = (u4Tmp & bMaskHWord)>>16;
> + regLPRx = (u4Tmp & bMaskHWord) >> 16;
>
> pCoexSta->highPriorityTx = regHPTx;
> pCoexSta->highPriorityRx = regHPRx;
> @@ -1317,7 +1317,7 @@ static void halbtc8723b1ant_SetFwPstdma(
> pBtCoexist->fBtcGet(pBtCoexist, BTC_GET_BL_WIFI_AP_MODE_ENABLE, &bApEnable);
>
> if (bApEnable) {
> - if (byte1&BIT4 && !(byte1&BIT5)) {
> + if (byte1 & BIT4 && !(byte1 & BIT5)) {
> BTC_PRINT(
> BTC_MSG_INTERFACE,
> INTF_NOTIFY,
> @@ -1349,9 +1349,9 @@ static void halbtc8723b1ant_SetFwPstdma(
> (
> "[BTCoex], PS-TDMA H2C cmd = 0x%x%08x\n",
> H2C_Parameter[0],
> - H2C_Parameter[1]<<24|
> - H2C_Parameter[2]<<16|
> - H2C_Parameter[3]<<8|
> + H2C_Parameter[1] << 24 |
> + H2C_Parameter[2] << 16 |
> + H2C_Parameter[3]<< 8 |
Why did you miss the space that is needed here too?
Did you run this patch through checkpatch.pl?
Please do so.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-06 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 13:01 [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operators Fabio M. De Francesco
2021-04-06 14:12 ` Greg KH [this message]
2021-04-06 14:22 ` FMDF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGxsNVs+sexiPMJS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox