* [PATCH] staging: media: zoran: reduce length of a line
@ 2021-04-08 21:21 Mitali Borkar
2021-04-09 7:26 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Mitali Borkar @ 2021-04-08 21:21 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel,
mitali_s
Reduced length of a line which exceed the 100 columns limit by splitting
the line into two statements and commenting it with '*'
Reported by checkpatch.
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
drivers/staging/media/zoran/zr36060.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
index 4f9eb9ff2c42..035634fc1c6d 100644
--- a/drivers/staging/media/zoran/zr36060.c
+++ b/drivers/staging/media/zoran/zr36060.c
@@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC
static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
-/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */
+/* SOF (start of frame) segment depends on width,
+ * height and sampling ratio of each color component
+ */
static int zr36060_set_sof(struct zr36060 *ptr)
{
char sof_data[34]; // max. size of register set
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: media: zoran: reduce length of a line
2021-04-08 21:21 [PATCH] staging: media: zoran: reduce length of a line Mitali Borkar
@ 2021-04-09 7:26 ` Hans Verkuil
2021-04-11 11:54 ` Mitali Borkar
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2021-04-09 7:26 UTC (permalink / raw)
To: Mitali Borkar, clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel,
mitali_s
Hi Mitali,
Something to improve:
On 08/04/2021 23:21, Mitali Borkar wrote:
> Reduced length of a line which exceed the 100 columns limit by splitting
> the line into two statements and commenting it with '*'
> Reported by checkpatch.
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
> drivers/staging/media/zoran/zr36060.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
> index 4f9eb9ff2c42..035634fc1c6d 100644
> --- a/drivers/staging/media/zoran/zr36060.c
> +++ b/drivers/staging/media/zoran/zr36060.c
> @@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC
> static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
> static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
>
> -/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */
> +/* SOF (start of frame) segment depends on width,
> + * height and sampling ratio of each color component
> + */
See the coding style guidelines: the preferred style for long comments is:
/*
* text
* text
*/
Regards,
Hans
> static int zr36060_set_sof(struct zr36060 *ptr)
> {
> char sof_data[34]; // max. size of register set
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: media: zoran: reduce length of a line
2021-04-09 7:26 ` Hans Verkuil
@ 2021-04-11 11:54 ` Mitali Borkar
0 siblings, 0 replies; 3+ messages in thread
From: Mitali Borkar @ 2021-04-11 11:54 UTC (permalink / raw)
To: Hans Verkuil
Cc: clabbe, mchehab, gregkh, linux-media, linux-staging, linux-kernel,
outreachy-kernel, mitali_s
On Fri, Apr 09, 2021 at 09:26:48AM +0200, Hans Verkuil wrote:
> Hi Mitali,
>
> Something to improve:
>
> On 08/04/2021 23:21, Mitali Borkar wrote:
> > Reduced length of a line which exceed the 100 columns limit by splitting
> > the line into two statements and commenting it with '*'
> > Reported by checkpatch.
> >
> > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> > ---
> > drivers/staging/media/zoran/zr36060.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
> > index 4f9eb9ff2c42..035634fc1c6d 100644
> > --- a/drivers/staging/media/zoran/zr36060.c
> > +++ b/drivers/staging/media/zoran/zr36060.c
> > @@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC
> > static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
> > static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
> >
> > -/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */
> > +/* SOF (start of frame) segment depends on width,
> > + * height and sampling ratio of each color component
> > + */
>
> See the coding style guidelines: the preferred style for long comments is:
>
> /*
> * text
> * text
> */
>
I have sent v2 patch two days ago and I have not got reply till now,
Should I resend this?
> Regards,
>
> Hans
>
> > static int zr36060_set_sof(struct zr36060 *ptr)
> > {
> > char sof_data[34]; // max. size of register set
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-11 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-08 21:21 [PATCH] staging: media: zoran: reduce length of a line Mitali Borkar
2021-04-09 7:26 ` Hans Verkuil
2021-04-11 11:54 ` Mitali Borkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox