From: Greg KH <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Julia Lawall <julia.lawall@inria.fr>,
outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove variable set but not used
Date: Mon, 12 Apr 2021 11:31:03 +0200 [thread overview]
Message-ID: <YHQTVwx+S82CAJyb@kroah.com> (raw)
In-Reply-To: <2836382.q67jgZTtOx@localhost.localdomain>
On Sun, Apr 11, 2021 at 08:12:05PM +0200, Fabio M. De Francesco wrote:
> On Sunday, April 11, 2021 7:43:57 PM CEST Julia Lawall wrote:
> > On Sun, 11 Apr 2021, Fabio M. De Francesco wrote:
> > > Remove variable "int ret" which is instantiated but not used.
> >
> > instantiated -> declared? I thought instantiated could mean initialized,
> > but that doesn't seem to be the case.
> >
> > julia
> Please, help me to remind...
>
> If a local variable is declared but not set to any value, does it take
> space on the stack?
Maybe, maybe not, doesn't matter either way.
> If I understand your message, it does not. Therefore it is only declared
> but no memory is allocated for it (i.e., it is not instantiated). Right?
>
> If you confirm I've understood this topic, I can send a v2 patch.
That's not the issue here at all...
confused,
greg k-h
next prev parent reply other threads:[~2021-04-12 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 17:41 [Outreachy kernel] [PATCH] staging: rtl8192u: Remove variable set but not used Fabio M. De Francesco
2021-04-11 17:43 ` Julia Lawall
2021-04-11 18:12 ` Fabio M. De Francesco
2021-04-12 9:31 ` Greg KH [this message]
2021-04-11 19:50 ` kernel test robot
2021-04-12 9:31 ` Greg KH
2021-04-12 10:23 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHQTVwx+S82CAJyb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fmdefrancesco@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox