From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738B771 for ; Mon, 12 Apr 2021 10:22:06 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 550316134F; Mon, 12 Apr 2021 10:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618222925; bh=uJJiofvCn1YyOHVdzJpT5k6jhpAFdOwokAiFuFAoabs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jXRedCTGmXBypQ7+CbP7cNSsslBauM+S2DOuSoEGdA+2nny1r1rhWbLB4qYo8XaYV aDPtUjv9N4qfnZuurTFJgLrh9XXEziIvfRicZLpZZgH4ddONXke83oRXgwxMieOCgC lTDi+mDgXcs8C7r2QfEZ7BrUS7BucItVMw5OHzNE= Date: Mon, 12 Apr 2021 12:22:03 +0200 From: Greg KH To: "Fabio M. De Francesco" Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove function Message-ID: References: <20210411184813.22836-1-fmdefrancesco@gmail.com> <4388012.RVq5xMhMDq@linux.local> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4388012.RVq5xMhMDq@linux.local> On Mon, Apr 12, 2021 at 12:12:34PM +0200, Fabio M. De Francesco wrote: > On Monday, April 12, 2021 11:42:51 AM CEST Greg KH wrote: > > On Sun, Apr 11, 2021 at 08:48:13PM +0200, Fabio M. De Francesco wrote: > > > Remove cmpk_handle_query_config_rx() because it just initializes a > > > local > > > variable and then returns "void". > > > > > > Signed-off-by: Fabio M. De Francesco > > > --- > > > > > > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 40 ------------------------ > > > 1 file changed, 40 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c > > > b/drivers/staging/rtl8192u/r819xU_cmdpkt.c index > > > 4cece40a92f6..d5a54c2d3086 100644 > > > --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c > > > +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c > > > @@ -249,46 +249,6 @@ static void cmpk_handle_interrupt_status(struct > > > net_device *dev, u8 *pmsg)> > > > DMESG("<---- cmpk_handle_interrupt_status()\n"); > > > > > > } > > > > > > -/*-------------------------------------------------------------------- > > > --------- - * Function: cmpk_handle_query_config_rx() > > > - * > > > - * Overview: The function is responsible for extract the message > > > from - * firmware. It will contain dedicated info in > > > - * ws-06-0063-rtl8190-command-packet-specification. > Please > > > - * refer to chapter "Beacon State Element". > > > - * > > > - * Input: u8 *pmsg - Message Pointer of the > command packet. > > > - * > > > - * Output: NONE > > > - * > > > - * Return: NONE > > > - * > > > - * Revised History: > > > - * When Who Remark > > > - * 05/12/2008 amy Create Version 0 porting from > windows code. > > > - * > > > - > > > *--------------------------------------------------------------------- > > > ------ - */ > > > -static void cmpk_handle_query_config_rx(struct net_device *dev, u8 > > > *pmsg) -{ > > > - struct cmpk_query_cfg rx_query_cfg; > > > - > > > - /* 1. Extract TX feedback info from RFD to temp structure > buffer. */ > > > - /* It seems that FW use big endian(MIPS) and DRV use little > endian in > > > - * windows OS. So we have to read the content byte by byte or > > > transfer > > > - * endian type before copy the message copy. > > > - */ > > > - rx_query_cfg.cfg_action = (pmsg[4] & 0x80) >> 7; > > > - rx_query_cfg.cfg_type = (pmsg[4] & 0x60) >> 5; > > > - rx_query_cfg.cfg_size = (pmsg[4] & 0x18) >> 3; > > > - rx_query_cfg.cfg_page = (pmsg[6] & 0x0F) >> 0; > > > - rx_query_cfg.cfg_offset = pmsg[7]; > > > - rx_query_cfg.value = (pmsg[8] << 24) | > (pmsg[9] << 16) | > > > - (pmsg[10] << 8) > | (pmsg[11] << 0); > > > - rx_query_cfg.mask = (pmsg[12] << 24) | > (pmsg[13] << 16) | > > > - (pmsg[14] << 8) > | (pmsg[15] << 0); > > > -} > > > - > > > > > > /*-------------------------------------------------------------------- > > > ---------> > > > * Function: cmpk_count_tx_status() > > > * > > > > Always test-build your patches as they can not break the build. You > > obviously did not do that here, why not? > > > I can't see that where the build of rtl8192u is broken. > The following lines are from the compilation log: > > git/kernels/staging> make -j8 drivers/staging/rtl8192u/ > [...] > CC [M] drivers/staging/rtl8192u/r819xU_cmdpkt.o > CC [M] drivers/staging/rtl8192u/r819xU_cmdpkt.o > [...] > LD [M] drivers/staging/rtl8192u/r8192u_usb.o > > No errors are reported. > > What am I missing? The function is used elsewhere in this file :(