From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09BF36D24 for ; Wed, 14 Apr 2021 17:00:44 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 006F36100C; Wed, 14 Apr 2021 17:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618419644; bh=bx3oAhc3i0mDHsdiCnxOJmKJyC0pV+jZkUkWvJEyymM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EhJPySsNEiHohK1eUnPv+7AISSQSolQAOHIf1JcytVGbpll0b7lx57shEbTucdYoA 55dNBhifRNpWGxpuPPqJzMFnlaK2LQUu7VJ2zbi2SkmPPolFH88fTTbeJR6YLrjxLi b36Zp+czDap/SLfu/b0fpthifsSAcJxH8LmEBfsY= Date: Wed, 14 Apr 2021 19:00:41 +0200 From: Greg Kroah-Hartman To: "Fabio M. De Francesco" Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Matthew Wilcox , Julia Lawall , Dan Carpenter Subject: Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl() Message-ID: References: <20210414162614.14867-1-fmdefrancesco@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414162614.14867-1-fmdefrancesco@gmail.com> On Wed, Apr 14, 2021 at 06:26:14PM +0200, Fabio M. De Francesco wrote: > Removed useless led_blink_hdl() prototype and definition. In wlancmds[] > the slot #60 is now set to NULL using the macro GEN_MLME_EXT_HANDLER. This > change has not unwanted side effects because the code in rtw_cmd.c checks > if the function pointer is valid before using it. > > Reported-by: Julia Lawall > Suggested-by: Dan Carpenter > Signed-off-by: Fabio M. De Francesco > --- > > Changes since v1: Corrected a bad solution to this issue that made use of > an unnecessary dummy function. > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 --------- > drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 1 - > 3 files changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c > index 0297fbad7bce..f82dbd4f4c3d 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > @@ -150,7 +150,7 @@ static struct cmd_hdl wlancmds[] = { > > GEN_MLME_EXT_HANDLER(0, h2c_msg_hdl) /*58*/ > GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelPlan_param), set_chplan_hdl) /*59*/ > - GEN_MLME_EXT_HANDLER(sizeof(struct LedBlink_param), led_blink_hdl) /*60*/ > + GEN_MLME_EXT_HANDLER(0, NULL) /*60*/ Better, but you really do not need to keep this here, right? Remove the "led blink command" entirely, you didn't do that here. thanks, greg k-h