From: Greg KH <gregkh@linuxfoundation.org>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: joe@perches.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 50/50] staging: rtl8723bs: macro DRIVER_PREFIX expands to lowercase driver name
Date: Tue, 27 Apr 2021 16:03:04 +0200 [thread overview]
Message-ID: <YIgZmPf9JckEyEpI@kroah.com> (raw)
In-Reply-To: <20210427124134.GA1399@agape.jhs>
On Tue, Apr 27, 2021 at 02:41:35PM +0200, Fabio Aiuto wrote:
> On Tue, Apr 27, 2021 at 01:04:09PM +0200, Greg KH wrote:
> > On Sat, Apr 24, 2021 at 11:02:33AM +0200, Fabio Aiuto wrote:
> > > macro DRIVER_PREFIX expands to lowercase driver name.
> > >
> > > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> > > ---
> > > drivers/staging/rtl8723bs/include/rtw_debug.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h
> > > index 189f02a8300a..3a5b083e95a1 100644
> > > --- a/drivers/staging/rtl8723bs/include/rtw_debug.h
> > > +++ b/drivers/staging/rtl8723bs/include/rtw_debug.h
> > > @@ -7,7 +7,7 @@
> > > #ifndef __RTW_DEBUG_H__
> > > #define __RTW_DEBUG_H__
> > >
> > > -#define DRIVER_PREFIX "RTL8723BS: "
> > > +#define DRIVER_PREFIX "rtl8723bs: "
> >
> > KBUILD_MODNAME should be used here, in the future.
>
> ok, got it
>
> >
> > But really, this shouldn't be needed at all, it's kind of pointless (if
> > it is being used, then odds are the places it is being used is wrong...)
> >
> > thanks,
> >
> > greg k-h
>
> fabio@agape:~/src/git/kernels/staging$ grep -r DRIVER_PREFIX drivers/staging/rtl8723bs/
> drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c: print_hex_dump_debug(DRIVER_PREFIX ": u1H2CRsvdPageParm:", DUMP_PREFIX_NONE,
> drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c: print_hex_dump_debug(DRIVER_PREFIX ": u1H2CMediaStatusRptParm:", DUMP_PREFIX_NONE,
> drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c: print_hex_dump_debug(DRIVER_PREFIX ": u1H2CMacIdConfigParm:", DUMP_PREFIX_NONE,
> drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c: print_hex_dump_debug(DRIVER_PREFIX ": u1H2CRssiSettingParm:", DUMP_PREFIX_NONE,
> drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c: print_hex_dump_debug(DRIVER_PREFIX ": u1H2CPwrModeParm:", DUMP_PREFIX_NONE,
> drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c: print_hex_dump_debug(DRIVER_PREFIX ": u1H2CPsTuneParm:", DUMP_PREFIX_NONE,
> drivers/staging/rtl8723bs/hal/hal_com.c: print_hex_dump_debug(DRIVER_PREFIX ": c2h_evt_read(): ", DUMP_PREFIX_NONE,
> drivers/staging/rtl8723bs/hal/hal_com.c: print_hex_dump_debug(DRIVER_PREFIX ": c2h_evt_read(): Command Content:\n",
> drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c: print_hex_dump_debug(DRIVER_PREFIX ": C2HPacketHandler_8723B(): Command Content:\n",
Drivers should not be dumping hex data like this to the kernel log, I
bet they can all be removed :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-27 14:03 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 9:01 [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 01/50] staging: rtl8723bs: remove unused log function Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 02/50] staging: rtl8723bs: replace DBG_871X_SEL log macro with netdev_dbg() Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 03/50] staging: rtl8723bs: add two functions to improve register dump in core/rtw_debug.c Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 04/50] staging: rtl8723bs: remove DBG_871X_SEL macro declaration Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 05/50] staging: rtl8723bs: remove unused _DBG_871X_LEVEL macro Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 06/50] staging: rtl8723bs: remove unused mac_reg_dump() function argument Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 07/50] staging: rtl8723bs: remove unused bb_reg_dump() " Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 08/50] staging: rtl8723bs: remove unused rf_reg_dump() " Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 09/50] staging: rtl8723bs: remove unused RTW_DBGDUMP macro definition Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 10/50] staging: rtl8723bs: remove all defs related to _dbgdump macro Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 11/50] staging: rtl8723bs: remove unused debug variables declarations and initialization Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 12/50] staging: rtl8723bs: remove unneeded header file include Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 13/50] staging: rtl8723bs: remove unused debug macro definitions Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 14/50] staging: rtl8723bs: remove debug macros related to core/rtw_xmit.c tracing Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 15/50] staging: rtl8723bs: remove debug macros related to os_dep/xmit_linux.c tracing Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 16/50] staging: rtl8723bs: remove debug macros related to core/rtw_recv.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 17/50] staging: rtl8723bs: remove debug macros related to os_dep/recv_linux.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 18/50] staging: rtl8723bs: remove debug macros related to core/rtw_mlme.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 19/50] staging: rtl8723bs: remove debug macros related to os_dep/mlme_linux.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 20/50] staging: rtl8723bs: move static array definition from header to .c file Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 21/50] staging: rtl8723bs: remove debug macros related to core/rtw_mlme_ext.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 22/50] staging: rtl8723bs: remove debug macros related to core/rtw_sta_mgt.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 23/50] staging: rtl8723bs: remove debug macros related to core/rtw_cmd.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 24/50] staging: rtl8723bs: remove obsolete debug macro definitions Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 25/50] staging: rtl8723bs: remove debug macros related to core/rtw_io.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 26/50] staging: rtl8723bs: remove obsolete _IO_OSDEP_C_ debug macro definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 27/50] staging: rtl8723bs: remove debug macros related to os_dep/os_intfs.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 28/50] staging: rtl8723bs: remove debug macros related to core/rtw_security.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 29/50] staging: rtl8723bs: remove debug macros related to core/rtw_eeprom.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 30/50] staging: rtl8723bs: remove debug macros related to hal/hal_intf.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 31/50] staging: rtl8723bs: remove debug macros related to hal/sdio_halinit.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 32/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 33/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_SET_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 34/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_QUERY_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 35/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_PWRCTRL_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 36/50] staging: rtl8723bs: remove unused macros tied to core/rtw_pwrctrl.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 37/50] staging: rtl8723bs: remove unused macros tied to os_dep/sdio_intf.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 38/50] staging: rtl8723bs: remove unused debug macros tied to _HCI_OPS_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 39/50] staging: rtl8723bs: remove unused debug macros tied to hal/sdio_ops.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 40/50] staging: rtl8723bs: remove unused debug macros tied to os_dep/osdep_service.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 41/50] staging: rtl8723bs: remove unused _module_mp_ def Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 42/50] staging: rtl8723bs: remove unused macros tied to _HCI_OPS_OS_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 43/50] staging: rtl8723bs: remove unused macros tied to _RTL871X_IOCTL_LINUX_C definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 44/50] staging: rtl8723bs: remove unused macros tied to _RTL8712_CMD_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 45/50] staging: rtl8723bs: remove commented out macro definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 46/50] staging: rtl8723bs: remove unused debug macro definitions Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 47/50] staging: rtl8723bs: remove unused macros tied to core/rtw_efuse.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 48/50] staging: rtl8723bs: remove unsed debug macros tied to no particular code debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 49/50] staging: rtl8723bs: remove last unused debug macros Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 50/50] staging: rtl8723bs: macro DRIVER_PREFIX expands to lowercase driver name Fabio Aiuto
2021-04-27 11:04 ` Greg KH
2021-04-27 12:41 ` Fabio Aiuto
2021-04-27 14:03 ` Greg KH [this message]
2021-04-27 11:06 ` [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h Greg KH
2021-04-27 12:42 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIgZmPf9JckEyEpI@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fabioaiuto83@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).