From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F2E472 for ; Fri, 14 May 2021 14:05:36 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id EE8A461476; Fri, 14 May 2021 14:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621001135; bh=3X/2sKQU+VZtoQXXKlhTlk6dEmdniKN4gTMiCrvOMc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tvYrwjHIwDwJSCuKkETrP6xd3VDwge8PFmjLcHVFnuqc7tt89/W999mgBAIXoqhQJ m76RaDjoo/X+aES92ivmdXX6/g4gvMoAfOlHOJsy8mTN5bX9XgLQ7syOyOU7bzwg5E M5qCopTvSqeIAaNVZR3LQg4JkOra9kCf2xZffS5s= Date: Fri, 14 May 2021 16:05:32 +0200 From: Greg KH To: Shreyansh Chouhan Cc: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: fix gb_loopback_stats_attrs definition Message-ID: References: <20210514133039.304760-1-chouhan.shreyansh630@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 14, 2021 at 07:18:38PM +0530, Shreyansh Chouhan wrote: > On Fri, May 14, 2021 at 03:36:25PM +0200, Greg KH wrote: > > On Fri, May 14, 2021 at 07:00:39PM +0530, Shreyansh Chouhan wrote: > > > The gb_loopback_stats_attrs macro, (defined in loopback.c,) is a > > > multiline macro whose statements were not enclosed in a do while > > > loop. > > > > > > This patch adds a do while loop around the statements of the said > > > macro. > > > > > > Signed-off-by: Shreyansh Chouhan > > > --- > > > drivers/staging/greybus/loopback.c | 10 ++++++---- > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > > > index 2471448ba42a..c88ef3e894fa 100644 > > > --- a/drivers/staging/greybus/loopback.c > > > +++ b/drivers/staging/greybus/loopback.c > > > @@ -162,10 +162,12 @@ static ssize_t name##_avg_show(struct device *dev, \ > > > } \ > > > static DEVICE_ATTR_RO(name##_avg) > > > > > > -#define gb_loopback_stats_attrs(field) \ > > > - gb_loopback_ro_stats_attr(field, min, u); \ > > > - gb_loopback_ro_stats_attr(field, max, u); \ > > > - gb_loopback_ro_avg_attr(field) > > > +#define gb_loopback_stats_attrs(field) \ > > > + do { \ > > > + gb_loopback_ro_stats_attr(field, min, u); \ > > > + gb_loopback_ro_stats_attr(field, max, u); \ > > > + gb_loopback_ro_avg_attr(field); \ > > > + } while (0) > > > > > > #define gb_loopback_attr(field, type) \ > > > static ssize_t field##_show(struct device *dev, \ > > > -- > > > 2.31.1 > > > > > > > > > > Did you test build this change? > > I built the module using make -C . M=drivers/staging/greybus to test > build it. I didn't get any errors. Really? Can you provide the full build output for this file with your change? I don't think you really built this file for the obvious reasons... thanks, greg k-h