linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jordan Vaughn <jordanvaughn1@gmail.com>
Cc: ganesanr@broadcom.com, linux-staging@lists.linux.dev,
	Jordan Vaughn <jordvaughn1@gmail.com>,
	jchandra@broadcom.com
Subject: Re: [PATCH] netlogic: This patch formats existing comments to Linux standards found in TODO.
Date: Mon, 3 May 2021 19:34:38 +0200	[thread overview]
Message-ID: <YJA0LrENB0DhSIzu@kroah.com> (raw)
In-Reply-To: <20210503170353.66415-1-jordvaughn1@gmail.com>

On Mon, May 03, 2021 at 05:03:53PM +0000, Jordan Vaughn wrote:
> Netlogic: xlr_net: Fix styling problems with comments 
> 
> Signed-off-by: Jordan Vaughn <jordvaughn1@gmail.com>
> ---
>  drivers/staging/netlogic/xlr_net.c | 67 +++++++++++++++---------------
>  drivers/staging/netlogic/xlr_net.h |  3 +-
>  2 files changed, 36 insertions(+), 34 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
> index 69ea61faf8fa..c1539b6b75b8 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -15,20 +15,19 @@
>  #include <linux/jiffies.h>
>  #include <linux/interrupt.h>
>  #include <linux/platform_device.h>
> -

This was not a comment change :(

And please write a better changelog.

>  #include <asm/mipsregs.h>
> -/*
> +
> +/**

That's a kernel-doc format marker, why did you do that?

thanks,

greg k-h

  reply	other threads:[~2021-05-03 17:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 17:03 [PATCH] netlogic: This patch formats existing comments to Linux standards found in TODO Jordan Vaughn
2021-05-03 17:34 ` Greg KH [this message]
2021-05-04  8:17 ` Dan Carpenter
2021-05-04  8:29   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJA0LrENB0DhSIzu@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ganesanr@broadcom.com \
    --cc=jchandra@broadcom.com \
    --cc=jordanvaughn1@gmail.com \
    --cc=jordvaughn1@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).