From: Greg KH <gregkh@linuxfoundation.org>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: rtl8723bs: use in-kernel aes encryption in OMAC1 routines
Date: Tue, 4 May 2021 15:32:02 +0200 [thread overview]
Message-ID: <YJFM0igHeonjMra5@kroah.com> (raw)
In-Reply-To: <8c1c680a6498045746ca579e4caa3c87d13b3b49.1620133620.git.fabioaiuto83@gmail.com>
On Tue, May 04, 2021 at 03:12:56PM +0200, Fabio Aiuto wrote:
> --- a/drivers/staging/rtl8723bs/include/rtw_security.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_security.h
> @@ -7,6 +7,7 @@
> #ifndef __RTW_SECURITY_H_
> #define __RTW_SECURITY_H_
>
> +#include <crypto/aes.h>
Why put this .h in a .h file? Why not just put it in the .c file(s)
that need it?
You will note that this .h file does not have any other #include lines
in it...
thanks,
greg k-h
next prev parent reply other threads:[~2021-05-04 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 13:12 [PATCH 0/3] staging: rtl8723bs: use in-kernel aes encryption Fabio Aiuto
2021-05-04 13:12 ` [PATCH 1/3] staging: rtl8723bs: align argument position in a new line Fabio Aiuto
2021-05-04 13:12 ` [PATCH 2/3] staging: rtl8723bs: use in-kernel aes encryption in OMAC1 routines Fabio Aiuto
2021-05-04 13:32 ` Greg KH [this message]
2021-05-04 13:12 ` [PATCH 3/3] staging: rtl8723bs: use in-kernel aes encryption Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJFM0igHeonjMra5@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fabioaiuto83@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).