From: Greg KH <gregkh@linuxfoundation.org>
To: Bixuan Cui <cuibixuan@huawei.com>
Cc: dan.carpenter@oracle.com, desmondcheongzx@gmail.com,
marcocesati@gmail.com, fabioaiuto83@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next] staging: rtl8723bs: HalBtc8723b1Ant.c: Remove unused variables
Date: Thu, 27 May 2021 13:01:28 +0200 [thread overview]
Message-ID: <YK98CL3+Gg5hGH9g@kroah.com> (raw)
In-Reply-To: <20210526074537.46259-1-cuibixuan@huawei.com>
On Wed, May 26, 2021 at 03:45:37PM +0800, Bixuan Cui wrote:
> Fix the build warning: [-Wunused-but-set-variable]
>
> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2710:6: warning: variable ‘u4Tmp’ set but not used
> 2710 | u32 u4Tmp;
> | ^~~~~
> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2709:13: warning: variable ‘u1Tmpb’ set but not used
> 2709 | u8 u1Tmpa, u1Tmpb;
> | ^~~~~~
> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2709:5: warning: variable ‘u1Tmpa’ set but not used
> 2709 | u8 u1Tmpa, u1Tmpb;
> | ^~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> ---
> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> index 518d5354bda4..adfdc4f14b08 100644
> --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> @@ -2706,9 +2706,6 @@ void EXhalbtc8723b1ant_ScanNotify(struct btc_coexist *pBtCoexist, u8 type)
> bool bBtCtrlAggBufSize = false;
> u8 aggBufSize = 5;
>
> - u8 u1Tmpa, u1Tmpb;
> - u32 u4Tmp;
> -
> if (pBtCoexist->bManualControl || pBtCoexist->bStopCoexDm)
> return;
>
> @@ -2716,9 +2713,9 @@ void EXhalbtc8723b1ant_ScanNotify(struct btc_coexist *pBtCoexist, u8 type)
> pCoexSta->bWiFiIsHighPriTask = true;
>
> halbtc8723b1ant_PsTdma(pBtCoexist, FORCE_EXEC, false, 8); /* Force antenna setup for no scan result issue */
> - u4Tmp = pBtCoexist->fBtcRead4Byte(pBtCoexist, 0x948);
> - u1Tmpa = pBtCoexist->fBtcRead1Byte(pBtCoexist, 0x765);
> - u1Tmpb = pBtCoexist->fBtcRead1Byte(pBtCoexist, 0x67);
> + pBtCoexist->fBtcRead4Byte(pBtCoexist, 0x948);
> + pBtCoexist->fBtcRead1Byte(pBtCoexist, 0x765);
> + pBtCoexist->fBtcRead1Byte(pBtCoexist, 0x67);
> } else {
> pCoexSta->bWiFiIsHighPriTask = false;
>
> --
> 2.17.1
>
>
Does not apply to my tree :(
next prev parent reply other threads:[~2021-05-27 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 7:45 [PATCH next] staging: rtl8723bs: HalBtc8723b1Ant.c: Remove unused variables Bixuan Cui
2021-05-27 11:01 ` Greg KH [this message]
2021-05-28 1:27 ` Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK98CL3+Gg5hGH9g@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cuibixuan@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=desmondcheongzx@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox