From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D350729CA for ; Fri, 28 May 2021 09:23:37 +0000 (UTC) IronPort-SDR: 2ptMpO6Jmd12QNv3Xf2qo0DH+Ecp8El4gPBdr9MFLu+Zi7LPOZsJ0HQaHAM1vUOfF4va7TNWbx jwFCDcv0BXWw== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="202930191" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="202930191" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 02:23:36 -0700 IronPort-SDR: OYJiS7GMVN3kdCP0T3Fk5QW14KYnzMOD98Qg35WhHpFHrXVXzw//2E/90UMf61risilBjandaz r9+dIO/YD33g== X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="465818184" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 02:23:33 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lmYiJ-00FHHv-24; Fri, 28 May 2021 12:23:31 +0300 Date: Fri, 28 May 2021 12:23:31 +0300 From: Andy Shevchenko To: Wolfram Sang , Hans de Goede , Mauro Carvalho Chehab , linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, Mika Westerberg , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Subject: Re: [PATCH v1 1/6] i2c: acpi: Export i2c_acpi_find_client_by_adev() for users Message-ID: References: <20210526124322.48915-1-andriy.shevchenko@linux.intel.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, May 27, 2021 at 10:26:33PM +0200, Wolfram Sang wrote: > On Wed, May 26, 2021 at 03:43:17PM +0300, Andy Shevchenko wrote: > > There is at least one user that will gain from the > > i2c_acpi_find_client_by_adev() being exported. > > No objections per se. But as the user is in staging, I want to ask if > the use there is really a solution we would also accept outside of > staging? Or is it a hack? The similar OF API is exported for users, although amount of users and their locations are different. The AtomISP driver is not in the best shape, I agree, but for now any possible steps to make it better would be good steps in my opinion. Later we may see if we can do this piece of code differently (IIRC current way is probably the best taking into account legacy platforms support). -- With Best Regards, Andy Shevchenko