From: Phillip Potter <phil@philpotter.co.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
straube.linux@gmail.com, kaixuxia@tencent.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: replace two ODM_RT_TRACE calls in hal/phy.c
Date: Thu, 10 Jun 2021 23:43:18 +0100 [thread overview]
Message-ID: <YMKVhgwbfLqWH3bd@KernelVM> (raw)
In-Reply-To: <20210609092106.GE1955@kadam>
On Wed, Jun 09, 2021 at 12:21:06PM +0300, Dan Carpenter wrote:
> On Wed, Jun 09, 2021 at 12:56:09AM +0100, Phillip Potter wrote:
> > Within rtl88eu_dm_txpower_track_adjust function, retrieve the struct
> > net_device pointer, and replace both calls to the ODM_RT_TRACE macro
> > with equivalent netdev_dbg calls, as well as modifying layout, wording
> > and spacing slightly. The purpose of this, and patches like it, is to
> > eventually remove the need for include/odm_debug.h, which is an overly
> > complex way of printing debug/tracing information about the driver.
> >
>
> In the original code DebugComponents is always zero so the ODM_RT_TRACE()
> stuff was dead code and could never be printed. I would prefer we just
> delete it all instead of fixing it.
>
> regards,
> dan carpenter
>
Dear Dan (and Greg),
Thank you for your feedback. I will just remove all the ODM_RT_TRACE
calls in a follow up patch set in that case.
Regards,
Phil
next prev parent reply other threads:[~2021-06-10 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 23:56 [PATCH] staging: rtl8188eu: replace two ODM_RT_TRACE calls in hal/phy.c Phillip Potter
2021-06-09 9:21 ` Dan Carpenter
2021-06-10 22:43 ` Phillip Potter [this message]
2021-06-09 10:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMKVhgwbfLqWH3bd@KernelVM \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kaixuxia@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox