From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8188eu: core: Remove set but unused variable
Date: Wed, 21 Jul 2021 15:41:34 +0200 [thread overview]
Message-ID: <YPgkDnqSKGUaej5i@kroah.com> (raw)
In-Reply-To: <2206478.VjXv8tfObp@localhost.localdomain>
On Wed, Jul 21, 2021 at 03:35:18PM +0200, Fabio M. De Francesco wrote:
> On Wednesday, July 21, 2021 10:18:34 AM CEST Greg Kroah-Hartman wrote:
> > On Thu, Jul 01, 2021 at 05:46:47PM +0200, Fabio M. De Francesco wrote:
> > > Remove variable sec_idx because is set but unused. Issue detected by
> > > GCC with -Wunused-variable.
> > >
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > >
> > > drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > Does not apply to my tree :(
> >
> Your tree changed while my patch was expecting your review. This happened
> because someone else worked on the same code while
> "the development tree you have sent a patch for is "closed"
> due to the timing of the merge window".
>
> Unfortunately, I was unaware of a similar patch in your queue because I
> didn't notice that it was sent to the linux-staging list a few days before
> mine.
>
> This is not the first time that something like this happens, so I think it's
> better to not work and send patches while you keep the development tree
> closed.
The only time it is "closed" is during the merge window. No need to
stop doing work during then, it's easy to rebase and resend if there are
ever problems.
thanks,
greg k-h
prev parent reply other threads:[~2021-07-21 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 15:46 [PATCH] staging: rtl8188eu: core: Remove set but unused variable Fabio M. De Francesco
2021-07-21 8:18 ` Greg Kroah-Hartman
2021-07-21 13:35 ` Fabio M. De Francesco
2021-07-21 13:41 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPgkDnqSKGUaej5i@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox