From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: include: Remove unused const definitions
Date: Thu, 5 Aug 2021 12:49:57 +0200 [thread overview]
Message-ID: <YQvCVZEU4WWLOdk9@kroah.com> (raw)
In-Reply-To: <20210802011025.23887-1-fmdefrancesco@gmail.com>
On Mon, Aug 02, 2021 at 03:10:25AM +0200, Fabio M. De Francesco wrote:
> Remove unused const definitions. Issues detected by sparse. Remove the
> '#ifdef' and '#endif' preprocessor directives that surround them.
Can you now also remove the unneeded comments that reference these
variables as they make even less sense now?
thanks,
greg k-h
prev parent reply other threads:[~2021-08-05 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 1:10 [PATCH] staging: r8188eu: include: Remove unused const definitions Fabio M. De Francesco
2021-08-05 10:49 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQvCVZEU4WWLOdk9@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox