From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EF6E177 for ; Wed, 11 Aug 2021 07:40:56 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A150760230; Wed, 11 Aug 2021 07:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628667656; bh=V/N3eN/dw5gSqAyCkP+gCTFP8cNeUSG7Vnrmvybg9YA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2nEEGo6qq4f/vChJviFvNJGOXUdcy2sE4Et/9BG/ML35x1TGhgsfEw5gTXUiWdINt ttGxCioO0qIIw83UY6v5FTymJIdfLouK9VD6KUJOg7OXzijRvWbuAMD6gVR+6EMjhW 4RQjquwm8YCOTFlMaKWo+P7hjklKwna7KOYnrSFk= Date: Wed, 11 Aug 2021 09:40:53 +0200 From: Greg KH To: Phillip Potter Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] staging: r8188eu: remove lines from Makefile that silence build warnings Message-ID: References: <20210810235047.177883-1-phil@philpotter.co.uk> <20210810235047.177883-9-phil@philpotter.co.uk> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210810235047.177883-9-phil@philpotter.co.uk> On Wed, Aug 11, 2021 at 12:50:47AM +0100, Phillip Potter wrote: > Remove the several lines from the Makefile that append EXTRA_CFLAGS options > to silence build warnings about unused variables, unused functions and such > like. This will enable cleanup of missed warnings, and easier spotting > of future such problems. > > Signed-off-by: Phillip Potter > --- > drivers/staging/r8188eu/Makefile | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile > index 152d6325b4d9..7f6658f931d1 100644 > --- a/drivers/staging/r8188eu/Makefile > +++ b/drivers/staging/r8188eu/Makefile > @@ -2,15 +2,6 @@ SHELL := /bin/bash > EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS) > EXTRA_CFLAGS += -O1 > > -EXTRA_CFLAGS += -Wno-unused-variable > -EXTRA_CFLAGS += -Wno-unused-value > -EXTRA_CFLAGS += -Wno-unused-label > -EXTRA_CFLAGS += -Wno-unused-parameter > -EXTRA_CFLAGS += -Wno-unused-function > -EXTRA_CFLAGS += -Wno-unused > - > -EXTRA_CFLAGS += -Wno-uninitialized > - Ah, that is why I didn't see any warnings! Thanks for these changes, will go queue them up now. greg k-h